Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| [AaveV3EthereumLido.ASSETS.sUSDe.A_TOKEN, 5], | ||
| [AaveV3Mantle.ASSETS.sUSDe.A_TOKEN, 5], | ||
| [AaveV3Mantle.ASSETS.USDe.A_TOKEN, 5], | ||
| ['0x24C1FaC3447C45137E5f1c2C54Fe9ed3F1EdeA61', 5], // sUSDe INK |
There was a problem hiding this comment.
not available on a new bgd version?
There was a problem hiding this comment.
not yet at least...
There was a problem hiding this comment.
Pull request overview
This PR adds Ethena points incentives (multiplier of 5x) for the sUSDe asset on the INK network (Aave V3 deployment). The change enables users who deposit sUSDe on INK to earn Ethena loyalty points at the same rate as other supported networks.
Changes:
- Added Ethena points multiplier (5x) for sUSDe on INK network
- Fixed formatting in package.json (added final newline)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/hooks/useEthenaIncentives.ts | Added hardcoded address entry for sUSDe A_TOKEN on INK with 5x multiplier |
| package.json | Added final newline for consistent formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
AGMASO
dismissed stale reviews from JoaquinBattilana and mgrabina
via
4204347
AGMASO
force-pushed
the
feat/ethena-ink
branch
from
4204347 to
7833686
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/hooks/useEthenaIncentives.ts:23
- The ETHENA_DATA_MAP lookup is case-sensitive. Adding a hardcoded INK aToken address increases the risk that
rewardedAssetcasing (often normalized withtoLowerCase()elsewhere in the codebase) won’t match and Ethena points won’t display. Consider normalizing both the stored keys and the lookup input (e.g., store keys lowercased and call.get(rewardedAsset.toLowerCase())), and if possible prefer an address-book constant (e.g.AaveV3InkWhitelabelassets) instead of a raw literal; if it must remain hardcoded, add a short comment explaining why/where it comes from (similar toreservePatches.ts’ “not yet in @bgd-labs/aave-address-book”).
Also, there appears to be a duplicate map entry for AaveV3Ethereum.ASSETS.PT_sUSDE_31JUL2025.A_TOKEN later in this same map—please remove the duplicate to avoid confusion (and prevent accidental value divergence later).
['0x24C1FaC3447C45137E5f1c2C54Fe9ed3F1EdeA61', 5], // sUSDe INK
[AaveV3Ethereum.ASSETS.PT_eUSDE_29MAY2025.A_TOKEN, 2],
[AaveV3Ethereum.ASSETS.PT_eUSDE_14AUG2025.A_TOKEN, 2],
[AaveV3Ethereum.ASSETS.PT_USDe_31JUL2025.A_TOKEN, 2],
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files