Skip to content

Fix for some edge cases#3

Open
alexk111 wants to merge 1 commit into
aario:masterfrom
alexk111:master
Open

Fix for some edge cases#3
alexk111 wants to merge 1 commit into
aario:masterfrom
alexk111:master

Conversation

@alexk111

Copy link
Copy Markdown

The PR covers two edge cases for some dialogs triggering an unwanted minimize:

  1. Overwrite dialogs in Firefox. Reproduced by Right-click on Image > Save image as > Pick an existing file. Fixed with the if (!windowB.closeable) check.
  2. Overlay windows in Krita. Reproduced by clicking any of these on the Top bar: Fill Gradients, Fill Patterns, Choose Brush Preset. Fixed with the ancestor comparison for both windows: getAncestorForTransientWindow(windowA) === getAncestorForTransientWindow(windowB)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant