Skip to content

Update fix_format.sh to use root yarn prettier scripts#112

Merged
jgindin merged 2 commits into
mainfrom
fix-format-script
Jul 22, 2026
Merged

Update fix_format.sh to use root yarn prettier scripts#112
jgindin merged 2 commits into
mainfrom
fix-format-script

Conversation

@jgindin

@jgindin jgindin commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

Make the fix_format.sh script use the same configuration as the the yarn prettier command by using that command and a new yarn prettier:check command.

Pre-launch Checklist

  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I read the [Style Guide].
  • I have added updates to the [CHANGELOG].
  • I updated/added relevant documentation.
  • My code changes (if any) have tests.
  • If my branch is on fork, I have verified that scripts/e2e_test.sh passes.

Update scripts/fix_format.sh to call root package.json yarn scripts.
Default CHECK_ONLY to true so format checks run by default.
Add prettier:check script to root and workspace package.json files.

TAG=agy
CONV=98e54060-798a-4573-8f25-3c54fe5bb3cf

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a prettier:check script across multiple package configurations and updates the fix_format.sh script to support argument parsing and run prettier via yarn. However, changing the default behavior of fix_format.sh to only check formatting contradicts its name and breaks the documented workflow. It is recommended to keep the default behavior as fixing formatting.

Comment thread scripts/fix_format.sh Outdated
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

⚡ A2UI Composer PR Preview

This Pull Request was closed. The preview environment at /pr/112/ has been fully decommissioned.

@jgindin
jgindin merged commit 67de0c2 into main Jul 22, 2026
13 checks passed
@jgindin
jgindin deleted the fix-format-script branch July 22, 2026 13:45
github-actions Bot added a commit that referenced this pull request Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants