Update fix_format.sh to use root yarn prettier scripts#112
Merged
Conversation
Update scripts/fix_format.sh to call root package.json yarn scripts. Default CHECK_ONLY to true so format checks run by default. Add prettier:check script to root and workspace package.json files. TAG=agy CONV=98e54060-798a-4573-8f25-3c54fe5bb3cf
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a prettier:check script across multiple package configurations and updates the fix_format.sh script to support argument parsing and run prettier via yarn. However, changing the default behavior of fix_format.sh to only check formatting contradicts its name and breaks the documented workflow. It is recommended to keep the default behavior as fixing formatting.
Contributor
⚡ A2UI Composer PR PreviewThis Pull Request was closed. The preview environment at |
suyangw-g
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the fix_format.sh script use the same configuration as the the
yarn prettiercommand by using that command and a newyarn prettier:checkcommand.Pre-launch Checklist