refactor(angular): remove legacy basic catalog component implementations - #2213
Draft
josemontespg wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the legacy Angular component implementations of the Basic Catalog and their associated tests in favor of universal Web Components from @a2ui/web_core. A review comment points out that the update to CHANGELOG.md under the ## Unreleased section accidentally deleted other unreleased changes (such as the toWebComponent adapter and updates to SurfaceComponent and AngularCatalog), which should be preserved.
josemontespg
marked this pull request as draft
August 8, 2026 03:41
josemontespg
force-pushed
the
angular-clean-basic-catalog-implementations
branch
2 times, most recently
from
August 8, 2026 03:44
d061d47 to
56a1564
Compare
josemontespg
commented
Aug 8, 2026
josemontespg
force-pushed
the
angular-clean-basic-catalog-implementations
branch
from
August 8, 2026 03:46
56a1564 to
de97200
Compare
josemontespg
force-pushed
the
angular-clean-basic-catalog-implementations
branch
from
August 8, 2026 04:04
de97200 to
a13dcf7
Compare
josemontespg
force-pushed
the
angular-clean-basic-catalog-implementations
branch
2 times, most recently
from
August 8, 2026 05:48
45db3e9 to
244c4b8
Compare
josemontespg
force-pushed
the
angular-clean-basic-catalog-implementations
branch
from
August 8, 2026 05:50
244c4b8 to
b4b8d35
Compare
josemontespg
force-pushed
the
angular-clean-basic-catalog-implementations
branch
from
August 8, 2026 05:52
b4b8d35 to
a183f16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes legacy Angular component implementations of the Basic Catalog in favor of the universal Web Component implementations provided by
@a2ui/web_core.Changes
renderers/angular/src/v0_9/catalog/basic/.BasicCatalogandBasicCatalogBaseconfigured with universal Web Components.renderers/angular/CHANGELOG.md.Verification
yarn --cwd renderers/angular test:unitpassed (166/166 tests).yarn format:all && yarn lint:allpassed cleanly.