refactor(web_core, lit): move universal basic catalog components to web_core and re-export in lit - #2190
Draft
josemontespg wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the A2UI Lit renderers by moving the core component implementations (such as Button, Card, List, Modal, Tabs, and Text) from the renderers/lit package into the renderers/web_core package under basic_catalog, updating the Lit package to re-export them. This consolidation improves cross-framework reusability. However, several issues were identified in the migrated components: DateTimeInput has bugs when enableDate is false and potential timezone issues; Modal uses the open attribute on <dialog> instead of .showModal(), losing native modal features; Tabs lacks safety clamping for activeIndex when the tabs array shrinks; Text incorrectly nests block-level elements inside an inline <span>; and List generates invalid CSS due to an empty styleType variable.
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 00:37
af2bfeb to
054c5ad
Compare
josemontespg
commented
Aug 7, 2026
josemontespg
changed the title
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
3 times, most recently
from
August 7, 2026 19:31
0c06b33 to
d7abba7
Compare
josemontespg
commented
Aug 7, 2026
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 20:07
d7abba7 to
10f6afb
Compare
josemontespg
changed the title
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 20:54
10f6afb to
2c00f51
Compare
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 20:59
2c00f51 to
570e9c4
Compare
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 21:52
570e9c4 to
e714efb
Compare
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 22:03
e714efb to
5e107cd
Compare
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 22:16
5e107cd to
5fbffe7
Compare
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 22:24
5fbffe7 to
535ac56
Compare
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
2 times, most recently
from
August 7, 2026 22:34
130d214 to
728b3e2
Compare
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 22:36
728b3e2 to
7383080
Compare
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 7, 2026 22:57
7383080 to
239fff0
Compare
josemontespg
commented
Aug 7, 2026
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
4 times, most recently
from
August 8, 2026 00:52
eeb6375 to
a5d1df7
Compare
josemontespg
commented
Aug 8, 2026
| @@ -1,5 +1,6 @@ | |||
| ## Unreleased | |||
|
|
|||
| - (v0_9) Move Basic Catalog components to `@a2ui/web_core` as universal Web Components. | |||
Collaborator
Author
There was a problem hiding this comment.
remove this entry since we are moving just the implementations but keeping the public API surface by re-exporting
Collaborator
Author
There was a problem hiding this comment.
Done! Removed this entry from the changelog.
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
4 times, most recently
from
August 8, 2026 05:48
acbd410 to
6ec7083
Compare
…eb_core and re-export in lit
josemontespg
force-pushed
the
basic-catalog-universal-components
branch
from
August 8, 2026 05:52
6ec7083 to
f771a10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Moves the 18 Basic Catalog Web Component implementations from
@a2ui/litinto@a2ui/web_core, making them available as framework-agnostic universal custom elements that can be shared across all web renderers.Details
AudioPlayer,Button,Card,CheckBox,ChoicePicker,Column,DateTimeInput,Divider,Icon,Image,List,Modal,Row,Slider,Tabs,Text,TextField,Video) into@a2ui/web_core/v0_9/basic_catalog/components/.BasicCatalogA2uiLitElementand controller utilities in@a2ui/web_core/v0_9/basic_catalogwith Light DOM rendering and shared styling.@a2ui/litwith JSDoc notices to ensure existing code and consumers continue working without breaking changes.@a2ui/web_core, utilizing a JSDOM testing environment for Node.js test execution.willUpdate), and custom element tags.