Skip to content

Conversation

@clarkngo
Copy link

@clarkngo clarkngo commented Dec 2, 2025

The server failed to start with a "ModuleNotFoundError" because FastAPI and Uvicorn were not listed in the project dependencies.

This commit adds fastapi and uvicorn to ensure the application starts correctly.

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #417 🦕

The server failed to start with a "ModuleNotFoundError" because
FastAPI and Uvicorn were not listed in the project dependencies.

This commit adds `fastapi` and `uvicorn` to ensure the application
starts correctly.

Fixes a2aproject#417
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @clarkngo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical startup failure in the a2a_gui server by incorporating a missing core dependency. By adding fastapi to the project's configuration, the application can now correctly initialize and operate, preventing previous module not found errors.

Highlights

  • Dependency Resolution: Added the fastapi dependency to the pyproject.toml file for the a2a_gui project. This resolves a ModuleNotFoundError that prevented the server from starting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the fastapi dependency, which is necessary to resolve the ModuleNotFoundError and allow the server to start. The change is straightforward and effective. I've included one minor suggestion to improve project maintainability by sorting the dependencies alphabetically. Note that the PR title and description mention adding uvicorn as well, but it was already present in the dependencies list.

clarkngo and others added 2 commits December 2, 2025 09:21
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing fastapi dependency on a2a_gui

1 participant