Skip to content

Conversation

@Moshiii
Copy link

@Moshiii Moshiii commented Nov 29, 2025

Description

This is for improvement of logging in hellow world client:
Screenshot 2025-11-29 at 7 18 22 PM

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Moshiii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user experience of the helloworld client by optimizing its logging behavior and enhancing the readability of its JSON output. The changes aim to make the client's console output cleaner and easier to parse, both for debugging and general observation.

Highlights

  • Logging Configuration: Suppressed verbose logging output from the 'a2a.client.client' module by setting its log level to WARNING, reducing noise in the console.
  • JSON Output Formatting: Updated the printing of Pydantic model responses to use model_dump_json with indent=2, ensuring pretty-printed and more readable JSON output.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Moshiii Moshiii closed this Nov 29, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the output of the helloworld test client by pretty-printing the JSON responses and suppressing verbose logs from the a2a.client.client library. The changes are good and improve readability. I've added a couple of minor suggestions to use the configured logger instead of print() for consistency with the rest of the script.


response = await client.send_message(request)
print(response.model_dump(mode='json', exclude_none=True))
print(response.model_dump_json(indent=2, exclude_none=True))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

For consistency with how other data structures are logged in this file (e.g., the agent card on lines 52-54), it would be better to use the configured logger instead of print(). This provides more flexible output control through logging configuration.

Suggested change
print(response.model_dump_json(indent=2, exclude_none=True))
logger.info(response.model_dump_json(indent=2, exclude_none=True))


async for chunk in stream_response:
print(chunk.model_dump(mode='json', exclude_none=True))
print(chunk.model_dump_json(indent=2, exclude_none=True))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

For consistency, it's better to use the configured logger here instead of print(), similar to the other logging calls in this file.

Suggested change
print(chunk.model_dump_json(indent=2, exclude_none=True))
logger.info(chunk.model_dump_json(indent=2, exclude_none=True))

@Moshiii Moshiii reopened this Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant