Skip to content

Conversation

@madankumarpichamuthu
Copy link
Contributor

Fixes inconsistent spelling of cancel-related terms across the specification and documentation. The proto definition uses TASK_STATE_CANCELLED (double 'l'), but various documentation files were using single 'l' spelling.

Changes:

  • canceled → cancelled (11 instances across 3 files)
  • cancelable → cancellable (4 instances across 2 files)
  • TaskNotCancelableError → TaskNotCancellableError (4 instances across 2 files)
  • URL: task-not-cancelable → task-not-cancellable (1 instance)

Files modified:

  • docs/specification.md
  • docs/llms.txt
  • docs/topics/life-of-a-task.md

All documentation now consistently uses double 'l' to match the proto definition and JSON naming conventions.

Fixes #1270

… documentation

Fixes inconsistent spelling of cancel-related terms across the specification
and documentation. The proto definition uses TASK_STATE_CANCELLED (double 'l'),
but various documentation files were using single 'l' spelling.

Changes:
- canceled → cancelled (11 instances across 3 files)
- cancelable → cancellable (4 instances across 2 files)
- TaskNotCancelableError → TaskNotCancellableError (4 instances across 2 files)
- URL: task-not-cancelable → task-not-cancellable (1 instance)

Files modified:
- docs/specification.md
- docs/llms.txt
- docs/topics/life-of-a-task.md

All documentation now consistently uses British English spelling (double 'l')
to match the proto definition and JSON naming conventions.

Fixes a2aproject#1270
@madankumarpichamuthu madankumarpichamuthu requested review from a team as code owners December 5, 2025 22:25
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @madankumarpichamuthu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a spelling inconsistency within the project's documentation and specification. It standardizes the use of 'cancelled' (with double 'l') and 'cancellable' throughout various files, ensuring alignment with the existing TASK_STATE_CANCELLED proto definition and JSON naming conventions. This change improves clarity and uniformity across the project's descriptive content.

Highlights

  • Spelling Standardization: Consistently updated 'canceled' to 'cancelled' and 'cancelable' to 'cancellable' across the documentation to match proto definitions.
  • Error Name Alignment: Renamed TaskNotCancelableError to TaskNotCancellableError to align with the new spelling convention.
  • URL Path Consistency: Modified the URL path task-not-cancelable to task-not-cancellable for uniformity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively standardizes the spelling of 'cancelled' and 'cancellable' across the documentation, which improves consistency and aligns with the proto definitions. The changes are well-contained and address the issue described. I've found one minor typo in the process, which I've commented on.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@holtskinner
Copy link
Member

I think we should consolidate on the American spelling (and update the spec itself)

In 0.3.0, only one of these British spellings (Cancelled) is used in the grpc spec

TASK_STATE_CANCELLED = 5;

Every other usage, including in JSON-RPC uses the American spelling.

"canceled",

We'll have to have at least one breaking change, but I think it's best to consolidate into the American spelling to have as few as possible. (Canceled, cancelable)

What do you think @darrelmiller ?

Fixes markdown linting errors (MD060) introduced by longer spelling variant.
The change from 'TaskNotCancelableError' to 'TaskNotCancellableError' added
characters to both the error name and description text.

Changes:
- Line 570: Added 1 space after error name, removed space before '(e.g.,'
- Line 1162: Added 1 space after error name and at end of URL column

This ensures all table pipes remain vertically aligned with the header row,
satisfying markdownlint's MD060 table alignment requirements.

Related to a2aproject#1270

Author: Madan Kumar Pichamuthu
@madankumarpichamuthu madankumarpichamuthu force-pushed the fix/1270-standardize-cancelled-spelling branch from 1d725f3 to 88235d1 Compare December 11, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Proto has TASK_STATE_CANCELLED, but parts of the text still use 'canceled'

4 participants