chore(deps): bump reth-primitives-traits from 39b9c8a to a12a32e#1338
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
chore(deps): bump reth-primitives-traits from 39b9c8a to a12a32e#1338dependabot[bot] wants to merge 1 commit intomainfrom
39b9c8a to a12a32e#1338dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [reth-primitives-traits](https://github.com/paradigmxyz/reth) from `39b9c8a` to `a12a32e`. - [Release notes](https://github.com/paradigmxyz/reth/releases) - [Commits](paradigmxyz/reth@39b9c8a...a12a32e) --- updated-dependencies: - dependency-name: reth-primitives-traits dependency-version: a12a32efff201f74da089aa352c5c932d8f95ad6 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
8ce0630 to
0f85af6
Compare
| version = "1.11.1" | ||
| source = "git+https://github.com/paradigmxyz/reth#39b9c8ae4b8fe86ae8a74ee545055d0cae071837" | ||
| version = "1.11.3" | ||
| source = "git+https://github.com/paradigmxyz/reth#c0f69973522b78054f0086459b5da7dc973f986a" |
Contributor
There was a problem hiding this comment.
Commit hash mismatch with PR intent
The PR description states the update should be to commit a12a32e, but the actual commit being used is c0f69973522b78054f0086459b5da7dc973f986a. This mismatch means:
- The intended fixes/features from commit
a12a32e(mentioned in PR description: tx_index span addition, deadlock fix, writer starvation fix) may not be included - An unintended commit
c0f6997is being used instead - This could introduce different bugs or miss critical fixes
Fix: Update the dependency to the correct commit:
source = "git+https://github.com/paradigmxyz/reth#a12a32efff201f74da089aa352c5c932d8f95ad6"
Suggested change
| source = "git+https://github.com/paradigmxyz/reth#c0f69973522b78054f0086459b5da7dc973f986a" | |
| source = "git+https://github.com/paradigmxyz/reth#a12a32efff201f74da089aa352c5c932d8f95ad6" |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Contributor
Author
|
Superseded by #1351. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps reth-primitives-traits from
39b9c8atoa12a32e.Commits
a12a32efeat(engine): add tx_index to execute tx span (#22972)ec59698fix: don't deadlock on repeated payloads (#22971)9f69a68fix(ethstats): prevent writer starvation by cloning ConnWrapper to drop (#22805)4527725fix(reth-bench): preserve RequestsOrHash for engine_newPayloadV4 (#22939)c57ecb9fix(era-downloader): ignore NotFound when deleting out-of-range files (#22905)ea12781fix: resolve exit future once engine exits (#22956)adfa36efix(trie): ArenaParallelSparseTrie: fix merge_subtrie_updates not cancelling ...592c65brefactor(trie): box cleared_subtries pool entries (#22950)074daf8refactor(trie): simplify arena clear with drain and remove all_subtries (#22940)bb55687test(trie): Implement TrieTestHarness (#22923)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)