[Refactor] Finish provider stream helper rollout - #1169
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
No code issues found. Reviewed a8b2068 |
edelauna
approved these changes
Aug 6, 2026
edelauna
marked this pull request as ready for review
August 6, 2026 01:20
edelauna
requested review from
JamesRobert20,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 6, 2026 01:20
edelauna
enabled auto-merge
August 6, 2026 01:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Refactored the remaining provider specs in the stream-helper rollout to use the shared
asyncStreamFromandcollectStreamutilities. Scenario-specific throwing iterators remain inline where they are required to verify Bedrock error behavior, and obsolete lint suppressions were removed.Why this change was made
This completes the next incremental batch after the earlier provider rollouts, reducing repeated async-iterator setup and stream-draining boilerplate without hiding provider-specific assertions or failure paths.
Impact
Test-only refactor. Production behavior is unchanged; provider tests remain isolated and their existing assertions continue to exercise the same stream and error cases.
Related PRs