refactor(webview): canonicalize provider settings identifiers - #1143
refactor(webview): canonicalize provider settings identifiers#1143WebMad wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
🚧 Files skipped from review as they are similar to previous changes (16)
📝 WalkthroughWalkthroughProvider settings now use centralized ChangesProvider identifier migration
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
webview-ui/src/components/settings/providers/Kenari.tsxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. webview-ui/src/components/settings/providers/KimiCode.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. webview-ui/src/components/settings/providers/LiteLLM.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
webview-ui/src/components/settings/providers/__tests__/Requesty.spec.tsx (1)
45-45: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAssert the Requesty callback route.
Line 45 only checks that the URL contains
callback_url. Inwebview-ui/src/oauth/urls.ts, Lines 3-5 add this parameter for every provider. The test passes if the callback route uses another provider. Parse the URL and assert that the callback route ends in/${providerIdentifiers.requesty}.Proposed test update
- expect(screen.getByRole("link")).toHaveAttribute("href", expect.stringContaining("callback_url=")) + const callbackUrl = new URL(screen.getByRole("link").getAttribute("href") ?? "").searchParams.get( + "callback_url", + ) + expect(callbackUrl ?? "").toMatch(new RegExp(`/${providerIdentifiers.requesty}$`))🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@webview-ui/src/components/settings/providers/__tests__/Requesty.spec.tsx` at line 45, Strengthen the link assertion in the Requesty test by parsing the generated href and verifying its callback route ends with `/${providerIdentifiers.requesty}`. Keep the existing `callback_url` check if useful, but ensure the assertion specifically confirms Requesty rather than merely any provider callback.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webview-ui/src/components/settings/providers/LiteLLM.tsx`:
- Around line 64-65: Update the Save-handler invalidation calls using
queryClient.invalidateQueries for the LiteLLM and "all" routerModels keys so
their returned promises are explicitly handled; either await both invalidations
together or mark each intentional non-blocking call with void, preserving the
existing invalidation keys.
In `@webview-ui/src/components/settings/providers/OpenAICodex.tsx`:
- Line 3: Update the OpenAICodex component tests to remove calls to getByRole
for the deleted “Speed” combobox and instead assert that the
OpenAICodexSpeedSelector is absent in both affected tests. Leave the
service-tier compatibility tests in the API provider suite unchanged.
---
Nitpick comments:
In `@webview-ui/src/components/settings/providers/__tests__/Requesty.spec.tsx`:
- Line 45: Strengthen the link assertion in the Requesty test by parsing the
generated href and verifying its callback route ends with
`/${providerIdentifiers.requesty}`. Keep the existing `callback_url` check if
useful, but ensure the assertion specifically confirms Requesty rather than
merely any provider callback.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5a7309f4-7f15-4c4c-886e-f0419ee0f25f
📒 Files selected for processing (17)
webview-ui/src/components/settings/providers/Kenari.tsxwebview-ui/src/components/settings/providers/KimiCode.tsxwebview-ui/src/components/settings/providers/LiteLLM.tsxwebview-ui/src/components/settings/providers/Moonshot.tsxwebview-ui/src/components/settings/providers/OpenAICodex.tsxwebview-ui/src/components/settings/providers/OpenCodeGo.tsxwebview-ui/src/components/settings/providers/Poe.tsxwebview-ui/src/components/settings/providers/Requesty.tsxwebview-ui/src/components/settings/providers/Unbound.tsxwebview-ui/src/components/settings/providers/VercelAiGateway.tsxwebview-ui/src/components/settings/providers/ZooGateway.tsxwebview-ui/src/components/settings/providers/__tests__/CanonicalProviderIdentifiers.spec.tsxwebview-ui/src/components/settings/providers/__tests__/KimiCode.spec.tsxwebview-ui/src/components/settings/providers/__tests__/LiteLLM.spec.tsxwebview-ui/src/components/settings/providers/__tests__/Moonshot.spec.tsxwebview-ui/src/components/settings/providers/__tests__/Poe.spec.tsxwebview-ui/src/components/settings/providers/__tests__/Requesty.spec.tsx
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
github-actions
Bot
added
the
awaiting-review
|
A note on the two LiteLLM invalidations: there are currently two independent React Query entries for router models. |
c6cac6d to
a38deb9
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
1 participant
Summary
Extracts the provider-settings portion of #1141 into a focused pull request:
providerIdentifiersinwebview-ui/src/components/settings/providersSerialized provider values and runtime behavior remain unchanged.
Validation
pnpm check-typesinwebview-ui--prune-suppressions --max-warnings=0for all changed filesgit diff --checkRelated to #944. Extracted from #1141.
Summary by CodeRabbit
Bug Fixes
Tests