fix: CI failures and fromConstBuffer regression#502
Open
Hitomamacs wants to merge 4 commits into
Open
Conversation
- remove invalid -Dheavy and -Dfull build options from CI workflow - update ethos-u-core-driver repo URL (original was taken down) - set size = data.len in fromConstBuffer (regression from #498) - fix memory leak in codegen test templates
- restore len > 0 checks in deinit (freeing &.{} aborts on Linux)
- restore log_function referenced by op_qlinearconv.zig
Generated predict() intentionally calls both defer deinit() and explicit deinit() on intermediate tensors: defer as safety net, explicit for early memory reclamation. This pattern relies on deinit being idempotent (original behavior before #498). Restore: reset data/shape to empty after free so repeated calls are no-ops.
- make onnxsim import optional (commented out but still called) - add 5ms tolerance to 2D benchmark (matches 1D, flaky on CI runners)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beer regression still fails (never passed, since Oct 2025).