fix: relax mega_showdown versionRange to support new versioning scheme - #1
Open
ysaunier wants to merge 1 commit into
Open
fix: relax mega_showdown versionRange to support new versioning scheme#1ysaunier wants to merge 1 commit into
ysaunier wants to merge 1 commit into
Conversation
Mega Showdown changed its version format from "10.0.6-release-neoforge" to "1.7.3+1.7.3+1.21.1" (cobblemon version embedded in mod version). The old versionRange "[10.0.6-release-neoforge,)" rejects the new format, crashing on startup. Changing to "[1.0,)" accepts both schemes.
There was a problem hiding this comment.
Pull request overview
Relaxes the NeoForge dependency version range for the optional mega_showdown mod so that YellowCore can load with Mega Showdown’s new versioning scheme (e.g. 1.7.3+1.7.3+1.21.1) while still accepting the prior 10.x scheme.
Changes:
- Updated
mega_showdowndependencyversionRangefrom[10.0.6-release-neoforge,)to[1.0,)to accept both old and new version formats.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mega Showdown changed its version format from "10.0.6-release-neoforge" to "1.7.3+1.7.3+1.21.1" (cobblemon version embedded in mod version). The old versionRange "[10.0.6-release-neoforge,)" rejects the new format, crashing on startup. Changing to "[1.0,)" accepts both schemes.