feat(metrics): allow change influxdb interval #33767#2118
feat(metrics): allow change influxdb interval #33767#2118gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds configurability for the InfluxDB metrics reporting interval, so operators can tune how frequently metrics are pushed.
Changes:
- Introduces
InfluxDBIntervalinmetrics.Configwith a default of 10s. - Adds a CLI duration flag to set the InfluxDB reporting interval and wires it into config application.
- Uses the configured interval when starting the InfluxDB v1/v2 metrics exporters.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
metrics/config.go |
Extends metrics config with an InfluxDB reporting interval and sets a default. |
cmd/utils/flags.go |
Adds a new CLI duration flag and passes configured interval into InfluxDB exporters. |
cmd/XDC/main.go |
Registers the new metrics interval flag with the main CLI app. |
cmd/XDC/config.go |
Applies the new interval flag into the runtime metrics config. |
cmd/XDC/chaincmd.go |
Exposes the new interval flag on chain import command flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7b46817 to
3f8377c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3f8377c to
01e8c33
Compare
Proposed changes
allow change influxdb interval
Ref: ethereum#33767
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that