Open
Conversation
1y8ws7
force-pushed
the
receipt-event-fix
branch
from
4a27f42 to
e73b9c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a fix for the abscent
"receipt"event which is expected onweb3.eth.sendTransaction. A current workaround is to poll for the receipt. With this fix we'll be able to use a direct event, which is more efficient.Under the hood, web3 implementation for the receipt event relies on the
newHeadssubscription, which in turn useseth_getBlockByNumberrpc method call ineth-json-rpc-filterspackage. That call fails, because of the 0 padding for the requested block number.This fix was already done in the upstream repo: MetaMask/eth-json-rpc-filters#7.
We've back-ported this fix in a fork here: https://github.com/yodaplus/eth-json-rpc-filters/commits/3.0.3.
This PR updates the
eth-json-rpc-filterspackage to the patched fork.Additionally,
package-lock.jsonis normalize tonpm@6.4.1, which is a standard bundled version fornode@8.15.0, defined in.nvmrc.