feat: improve VCS waveform, coverage, and modern Verdi support - #94
Merged
Conversation
Makiras
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on three main areas:
VCSwaveform and coverage supportxspcommpath resolution and generated-project linking behaviorThe goal is to make the VCS flow more usable in real runs, make the example/test flows more consistent, and remove hardcoded assumptions about where
xspcommis installed.Main changes
1. VCS waveform and coverage support
--verdi-modeto select between legacy Verdi integration and modern-debug_access+alllibvcsnew.sovisibility workaround forVCSwhen--verdi-mode modernis selected2. Example directory structure and test entrypoints
output/<ExampleName>maketargets and align example scripts with the same output-root convention3. xspcomm path and linking fixes
/usr/local/libassumption from generatedmem_directbuildsxspcommpaths through picker and use them in generated link/runtime settingsMotivation / context
Before this PR:
mem_directprojects assumedxspcommlived in/usr/local/lib, which caused CI failures and made non-default installs unreliableAfter this PR:
xspcommpaths instead of a hardcoded system locationFixes # (issue)
Type of change
How Has This Been Tested?
Key validation performed for this change set:
__VERDI_MODE__to Python codegen datamem_directand confirmed it now uses picker-resolvedxspcommlibrary paths instead of/usr/local/libSuggested reproduction commands:
Checklist: