fix(ci): validate Docker image build on PR Docker changes - #93
Merged
Conversation
Run a Docker build validation job on pull requests when Dockerfile or .build-config.yml changes, without pushing the image. Also keep /tmp/build-config.yml until the Node installation step finishes so the Docker build can still resolve the configured Node version after the Verilator step.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds pull-request-time Docker image build validation when Docker-related files change, and adjusts the Dockerfile so .build-config.yml remains available long enough for Node version resolution during the image build.
Changes:
- Add CI jobs to detect PR changes to
Dockerfile/.build-config.ymland run a non-pushing Docker build as validation. - Update Dockerfile cleanup timing so
/tmp/build-config.ymlis removed after Node installation instead of after the Verilator step.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Delays removal of /tmp/build-config.yml until after Node install so later build steps can still read configured versions. |
| .github/workflows/ci.yml | Adds PR-only change detection and a Docker build-only validation job gated on Docker-related diffs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yaozhicheng
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run a Docker build validation job on pull requests when Dockerfile or .build-config.yml changes, without pushing the image.
Also keep /tmp/build-config.yml until the Node installation step finishes so the Docker build can still resolve the configured Node version after the Verilator step.
Type of change
Please delete options that are not relevant.
Checklist: