This repository was archived by the owner on Mar 28, 2022. It is now read-only.
Add API route for retrieving the item identification order#14
Open
phantamanta44 wants to merge 1 commit intoWynntils:masterfrom
Open
Add API route for retrieving the item identification order#14phantamanta44 wants to merge 1 commit intoWynntils:masterfrom
phantamanta44 wants to merge 1 commit intoWynntils:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it easier for external apps/mods to work with the Wynntils chat item format, since they no longer have to pull the full item list just to retrieve the identification order.
There's also an argument to be made for adopting some self-contained canonical ordering (e.g. alphabetical), but that's a conversation for some other time.