Skip to content

fix: resolve 7 latent issues and document 18 telemetry bugs#29

Merged
deer merged 3 commits intomainfrom
random_bug_fixes
Apr 1, 2026
Merged

fix: resolve 7 latent issues and document 18 telemetry bugs#29
deer merged 3 commits intomainfrom
random_bug_fixes

Conversation

@deer
Copy link
Copy Markdown
Collaborator

@deer deer commented Apr 1, 2026

Works through the latent issues backlog from docs/analysis.md, fixes 7 of the 10 items, and captures a new batch of telemetry bugs for a follow-up.

Fixes

  • RetryFrequency — within() had inverted floor/ceiling guards (valid inputs threw); never() called maxRetriesOf(0) which also threw. Tests added for both.
  • TextualRange.create() — checked start twice, never checked end. Test added.
  • Table.getRow(int) — off-by-one: > rows.size() should be >= rows.size(). Test added.
  • SchemaFactory — renamed getMashallingSchema → getMarshallingSchema and getUnmashallingSchemas → getUnmarshallingSchemas (missing 'r' in both).
  • @Unmarshal — restricted @Target to CONSTRUCTOR only; register() now throws a clear error if @Unmarshal is found on a method instead of silently ignoring it.
  • Progress.percentage() — changed return type from int to double (was truncating e.g. 33 instead of 33.3); also added division-by-zero guard for maximum == 0.

Docs

  • docs/analysis.md — crossed off completed items, marked deferred Connection work, added status column to priority ranking.
  • docs/telemetry-bugs.md (new) — 18 undocumented bugs across base-telemetry, base-telemetry-foundation, and base-telemetry-ansi, ranging from an always-NPE in TelemetryRecorder.diagnostic(Location, ...) to an off-by-one in the ANSI cursor movement that corrupts terminal output. Captured for a separate issue.

Not included

  • Connection serialization / synchronized issues (intentionally deferred)
  • Marshalling.GLOBAL_SCHEMA_FACTORY singleton (needs design discussion)
  • Telemetry bug fixes (tracked in docs/telemetry-bugs.md)

@deer deer merged commit c59d887 into main Apr 1, 2026
3 checks passed
@deer deer deleted the random_bug_fixes branch April 1, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant