Support Forums: Fix --wp-admin-theme-color CSS variable scope#554
Closed
yani- wants to merge 1 commit intoWordPress:trunkfrom
Closed
Support Forums: Fix --wp-admin-theme-color CSS variable scope#554yani- wants to merge 1 commit intoWordPress:trunkfrom
--wp-admin-theme-color CSS variable scope#554yani- wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Change the declaration from :root to body so it resolves var(--wp--preset--color--blueberry-1) which is defined on body by global-styles-inline-css. See https://meta.trac.wordpress.org/ticket/8175
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://meta.trac.wordpress.org/ticket/8175
The
--wp-admin-theme-colorcustom property is declared on:rootreferencingvar(--wp--preset--color--blueberry-1), but that variable is only defined onbodyby WordPress core'sglobal-styles-inline-css. Since:root(<html>)is the parent of
body, the referenced variable is not available in that scope.This changes the declaration from
:roottobodyso both variables aredefined on the same element and the reference resolves correctly.
Note: I used AI to generate the PR description and title. The source code has been reviewed and tested by me locally before opening this PR.