Open
Conversation
- script to determine churn/refactor with git show and git blame - update script to calculate modification not using diffstat tool
sang-d
approved these changes
Aug 4, 2020
sang-d
left a comment
sang-d
left a comment
There was a problem hiding this comment.
look great!
I'm not proficient with awk so this is a good learning for me.
I think it will be good performance and fast but might be bit hard for maintenance for example writing test. Probably need a wrapper for testing.
- changes in package-lock.json and other json files are too big: temporarily ignored *.json files - execute sql insert every 10 commit mark to avoid too many values error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
Screenshots & link (if appropriate)
Questions