Skip to content

1132 policies and data#1402

Merged
JasonWildMe merged 55 commits intomainfrom
1132_policies_and_data
Apr 15, 2026
Merged

1132 policies and data#1402
JasonWildMe merged 55 commits intomainfrom
1132_policies_and_data

Conversation

@erinz2020
Copy link
Copy Markdown
Contributor

@erinz2020 erinz2020 commented Jan 26, 2026

  1. cherry-pick 17 bumps prs in this pr
  2. add privacies and data menu in header -> Resources. it has 3 sub menus: privacy policies, terms of use, and citing wildbook
  3. add flag to control show/hide how to photograph page
  4. add a new page About us, under Resources
  5. add wildbook documentation under Resources
  6. move individual gallery and encounter calendar from "Animals" to "Data"

PR fixes #1132

erinz2020 and others added 10 commits January 19, 2026 21:25
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.12.
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 1.1.12
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.7 to 2.0.9.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.9/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v2.0.7...v2.0.9)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-version: 2.0.9
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.17.23)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.17.23
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.17.23)

---
updated-dependencies:
- dependency-name: lodash-es
  dependency-version: 4.17.23
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.23.9 to 7.27.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: "@babel/helpers"
  dependency-version: 7.27.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.25.9 to 7.27.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-version: 7.27.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [on-headers](https://github.com/jshttp/on-headers) and [compression](https://github.com/expressjs/compression). These dependencies needed to be updated together.

Updates `on-headers` from 1.0.2 to 1.1.0
- [Release notes](https://github.com/jshttp/on-headers/releases)
- [Changelog](https://github.com/jshttp/on-headers/blob/master/HISTORY.md)
- [Commits](jshttp/on-headers@v1.0.2...v1.1.0)

Updates `compression` from 1.7.4 to 1.8.1
- [Release notes](https://github.com/expressjs/compression/releases)
- [Changelog](https://github.com/expressjs/compression/blob/master/HISTORY.md)
- [Commits](expressjs/compression@1.7.4...v1.8.1)

---
updated-dependencies:
- dependency-name: on-headers
  dependency-version: 1.1.0
  dependency-type: indirect
- dependency-name: compression
  dependency-version: 1.8.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 27.17391% with 134 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.54%. Comparing base (a486d20) to head (bac8445).

Files with missing lines Patch % Lines
...tend/src/pages/PoliciesAndData/PoliciesAndData.jsx 0.00% 83 Missing ⚠️
frontend/src/pages/HowToPhotograph.jsx 0.00% 20 Missing ⚠️
...tend/src/components/header/HeaderDropdownItems.jsx 65.62% 11 Missing ⚠️
frontend/src/pages/AboutUs.jsx 0.00% 5 Missing ⚠️
...ages/ReportsAndManagamentPages/ReportEncounter.jsx 50.00% 5 Missing ⚠️
frontend/src/constants/navMenu.js 40.00% 3 Missing ⚠️
frontend/src/pages/Login.jsx 40.00% 3 Missing ⚠️
frontend/src/AuthenticatedSwitch.jsx 66.66% 2 Missing ⚠️
frontend/src/UnAuthenticatedSwitch.jsx 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   53.36%   52.54%   -0.83%     
==========================================
  Files         274      278       +4     
  Lines        9918    10066     +148     
  Branches     2955     3097     +142     
==========================================
- Hits         5293     5289       -4     
- Misses       4378     4524     +146     
- Partials      247      253       +6     
Flag Coverage Δ
backend 52.54% <27.17%> (-0.83%) ⬇️
frontend 52.54% <27.17%> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erinz2020 erinz2020 marked this pull request as ready for review January 29, 2026 20:50
@erinz2020 erinz2020 requested a review from vkirkl January 29, 2026 20:50
@erinz2020 erinz2020 marked this pull request as draft February 2, 2026 20:49
@erinz2020
Copy link
Copy Markdown
Contributor Author

@claude You are reviewing a code change as a senior engineer in an existing production codebase.

Your goal is to find only the most important issues that should realistically be addressed before merge.

Review principles:

Prioritize correctness, reliability, data flow, async behavior, state consistency, and real maintainability risks.
Do not comment on personal preference, code style, naming, or optional refactors.
Do not propose architecture changes unless the current implementation is clearly dangerous or broken.
Respect existing project conventions and favor minimal changes.
Do not invent missing requirements.
Be conservative: if something is acceptable, do not flag it.
Pay special attention to:

null / undefined access
React effect dependency mistakes
stale closures
race conditions
duplicate or inconsistent state
controlled/uncontrolled form issues
loading / error / empty-state logic
accidental rerenders with real impact
incorrect assumptions around async requests, polling, or derived data
Output:

Start with one line only:

"No merge-blocking issues found"
or "Found X important issues"
Then provide up to 3 issues only.

For each issue, use:

Severity: blocker | high | medium
Location: file / function / component
Problem:
Impact:
Minimal fix:
Do not include praise.
Do not include optional improvements.
Do not include “consider”, “might”, or “could” comments unless there is a concrete risk.

@claude

This comment was marked as outdated.

@erinz2020 erinz2020 added this to the 10.10 milestone Apr 14, 2026
@erinz2020
Copy link
Copy Markdown
Contributor Author

@claude You are reviewing a code change as a senior engineer in an existing production codebase.

Your goal is to find only the most important issues that should realistically be addressed before merge.

Review principles:

Prioritize correctness, reliability, data flow, async behavior, state consistency, and real maintainability risks.
Do not comment on personal preference, code style, naming, or optional refactors.
Do not propose architecture changes unless the current implementation is clearly dangerous or broken.
Respect existing project conventions and favor minimal changes.
Do not invent missing requirements.
Be conservative: if something is acceptable, do not flag it.
Pay special attention to:

null / undefined access
React effect dependency mistakes
stale closures
race conditions
duplicate or inconsistent state
controlled/uncontrolled form issues
loading / error / empty-state logic
accidental rerenders with real impact
incorrect assumptions around async requests, polling, or derived data
Output:

Start with one line only:

"No merge-blocking issues found"
or "Found X important issues"
Then provide up to 3 issues only.

For each issue, use:

Severity: blocker | high | medium
Location: file / function / component
Problem:
Impact:
Minimal fix:
Do not include praise.
Do not include optional improvements.
Do not include “consider”, “might”, or “could” comments unless there is a concrete risk.

@WildMeOrg WildMeOrg deleted a comment from claude Bot Apr 14, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Apr 14, 2026

Claude finished @erinz2020's task in 3m 32s —— View job


No merge-blocking issues found

Two findings from the previous review were false positives and are now corrected:

  • Lazy imports: All three new pages (HowToPhotograph, AboutUs, PoliciesAndData) are already wrapped in React.lazy() in both AuthenticatedSwitch.jsx and UnAuthenticatedSwitch.jsx. There are no static imports to fix.
  • Nav menu href mismatch: Both the authenticated menu (line 71) and unauthenticated menu (line 362) in navMenu.js already use ?section=privacy_policy as the "Policies and Data" parent href. There is no inconsistency.

The async PDF loading in PoliciesAndData.jsx correctly uses a cancelled flag to prevent stale state updates on fast section switching. The agree checkbox logic is consistently enforced in both Login.jsx (button disabled state) and ReportEncounter.jsx (button disabled state + runtime guard in handleSubmit). URL/state sync via the sectionParam effect is sound.

Copy link
Copy Markdown
Collaborator

@JasonWildMe JasonWildMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Codex. Approved. Thank you for addressing feedback.

@JasonWildMe JasonWildMe merged commit 0a43260 into main Apr 15, 2026
2 checks passed
@JasonWildMe JasonWildMe deleted the 1132_policies_and_data branch April 15, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates Terms of Use and Privacy Policy

4 participants