WIK-2212: Retry on Broken pipe and other transient network errors#9
Open
WIK-2212: Retry on Broken pipe and other transient network errors#9
Conversation
- Add retry loop (3 attempts) in CloudflareClient._request with exponential backoff (1s, 2s, 4s) and session refresh on retryable errors. - On Broken pipe, ConnectionError, aiohttp ClientError/ServerDisconnected, close the session and retry with a fresh connection. - Log 'Network error, retrying' with attempt and wait_time for observability. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses WIK-2212: AutoUAM gets Broken pipe errors frequently (e.g. on Wikizilla when enabling Under Attack Mode under high load).
Changes
CloudflareClient._request: up to 3 attempts with exponential backoff (1s, 2s, 4s).ConnectionError,aiohttp.ClientError/ServerDisconnectedError/ClientConnectorError,ConnectionResetError), the client closes the session and creates a new one on the next attempt so the retry uses a fresh TCP connection."Network error, retrying"witherror,attempt, andwait_timefor observability (aligned with existing log format seen in Jira).API failures (
CloudflareError) are not retried. All 24 existing tests pass.