Skip to content

feat: redirect to pool detail page after creation#821

Open
dev-fani wants to merge 1 commit into
Web3Novalabs:mainfrom
dev-fani:feat/redirect-to-pool-after-creation
Open

feat: redirect to pool detail page after creation#821
dev-fani wants to merge 1 commit into
Web3Novalabs:mainfrom
dev-fani:feat/redirect-to-pool-after-creation

Conversation

@dev-fani

Copy link
Copy Markdown

After pool creation is confirmed on-chain, the user is now redirected to the newly created pool's detail page.

Changes Made

  • After submitSignedXdr() succeeds, redirect to /pools/{poolId} using router.push()
  • Removed SuccessScreen component and submitted state since we now redirect directly
  • Added parseApiError import for proper error handling
  • Pool ID is captured from the createPool() response and used for the redirect

Deliverables

  • ✅ After submitSignedXdr() succeeds: calls router.push(/pools/\${poolId})
  • ✅ TypeScript validation passes (no diagnostics in modified file)
  • ✅ Code follows existing patterns in the file

Testing

The implementation follows the existing flow:

  1. User creates a pool (form submission)
  2. createPool() API returns { id, unsignedXdr }
  3. User signs the transaction via Freighter
  4. submitSignedXdr() submits the signed transaction
  5. NEW: On success, redirect to /pools/{poolId} (pool detail page)

Dependencies

Depends on #86 (submitSignedXdr implementation)

Notes

  • The pool ID comes from the original createPool() response as specified
  • On error, the user remains on the form with error feedback
  • The CI build will validate the changes properly with env vars configured

Closes #723

- After submitSignedXdr() succeeds, redirect to /pools/{poolId}
- Removed SuccessScreen component and submitted state
- Added parseApiError import for error handling
- Pool ID is captured from createPool() response and used for redirect

Resolves Web3Novalabs#723
@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@dev-fani Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@dev-fani

dev-fani commented Jul 2, 2026

Copy link
Copy Markdown
Author

hello maintainer, please merge my pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[S4] Redirect to new pool detail page after creation confirmed

1 participant