feat: redirect to pool detail page after creation#821
Open
dev-fani wants to merge 1 commit into
Open
Conversation
- After submitSignedXdr() succeeds, redirect to /pools/{poolId}
- Removed SuccessScreen component and submitted state
- Added parseApiError import for error handling
- Pool ID is captured from createPool() response and used for redirect
Resolves Web3Novalabs#723
|
@dev-fani Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
hello maintainer, please merge my pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After pool creation is confirmed on-chain, the user is now redirected to the newly created pool's detail page.
Changes Made
submitSignedXdr()succeeds, redirect to/pools/{poolId}usingrouter.push()SuccessScreencomponent andsubmittedstate since we now redirect directlyparseApiErrorimport for proper error handlingcreatePool()response and used for the redirectDeliverables
submitSignedXdr()succeeds: callsrouter.push(/pools/\${poolId})Testing
The implementation follows the existing flow:
createPool()API returns{ id, unsignedXdr }submitSignedXdr()submits the signed transaction/pools/{poolId}(pool detail page)Dependencies
Depends on #86 (
submitSignedXdrimplementation)Notes
createPool()response as specifiedCloses #723