Fix unnatural Japanese translations#206
Open
meow-meooow wants to merge 2 commits intoWeb3Auth:mainfrom
Open
Conversation
- Update translations for social login, wallet, network, etc.
shahbaz17
approved these changes
Jun 2, 2025
Member
shahbaz17
left a comment
shahbaz17
left a comment
There was a problem hiding this comment.
Thank you for your contribution, @meow-meooow
Keep this coming, appreciate the detailed look at these translations.
i18nlaurel
reviewed
Aug 7, 2025
| @@ -363,7 +363,7 @@ | |||
| "english": "Self-custody via", | |||
There was a problem hiding this comment.
@shahbaz17 Can you tell me what this full string might say, please? The Japanese linguist is confused what would come after "Self-custody via..". Thank you!
Member
There was a problem hiding this comment.
This is used in the previous versions to show
"Self-custody via Web3Auth"
i18nlaurel
reviewed
Aug 7, 2025
| @@ -699,7 +699,7 @@ | |||
| "english": "Continue with", | |||
There was a problem hiding this comment.
@shahbaz17 Can you also please help me with more context for this string?
Member
There was a problem hiding this comment.
This is Continue with {login provider name}
|
Thank you @shahbaz17! I passed this along to our linguist team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some of the Japanese sentences were strange and would cause distrust among users of the wallet (our service as well).
Description
I have likewise corrected the apparently incorrect wording that I found in the course of searching for the relevant section.
And in the process of creating this PR, I noticed that the “一般的な” at the top of the second image is also clearly wrong. It should be "一般".
Types of changes
Checklist: