Skip to content

chore: CLI readability cleanups from ShipGate auto-fix pass - #125

Closed
inquilabee wants to merge 1 commit into
VibePod:mainfrom
inquilabee:shipgate-readability-fixes
Closed

chore: CLI readability cleanups from ShipGate auto-fix pass#125
inquilabee wants to merge 1 commit into
VibePod:mainfrom
inquilabee:shipgate-readability-fixes

Conversation

@inquilabee

@inquilabee inquilabee commented Jul 30, 2026

Copy link
Copy Markdown

Small readability cleanups in the VibePod CLI core (src/vibepod) and related tests from a ShipGate auto-fix pass.

Summary

Review run with ShipGate 0.1.7.

ShipGate reported ~252 lint findings in the full check suite. This PR applies safe ruff/format fixes in core CLI modules; see the linked gist for raw captures.

Hotspots and improvement notes below are scoped to Python (*.py) source.

File hotspots

File Issues Action
src/vibepod/commands/task.py ~53 lint extract repeated strings; review private helpers
src/vibepod/core/docker.py ~35 lint simplify docker helper surface
src/vibepod/commands/run.py ~22 lint trim private helpers; review fixture overlap in tests only
tests/test_run.py ~15 lint align test helpers with production visibility
tests/test_overlay.py ~13 lint tighten type hints in overlay tests
src/vibepod/commands/skills.py ~11 lint reduce complexity in skills command
tests/test_task_cmd.py ~11 lint fix subscriptable/type issues in task tests
src/vibepod/core/skills_engine.py ~10 lint private helper cleanup

Refactor hints (optional apply)

No hint-tier refactor opportunities in scope (or refactor-strict.out empty).

What you are doing right

  • Dead code: vulture/deadcode found few or no unused symbols in production modules.
  • Tests: pytest passed locally (349 passed, 1 skipped).

What you could improve

  • Duplication (~5.4%): jscpd reports duplicate blocks — review clustered paths in hotspots.
  • Complexity: radon flagged modules above cyclomatic-complexity gates.
  • Hotspot: src/vibepod/commands/task.py concentrates the most findings.

Changes

Pass Files Fixes / rules Manual?
shipgate format + ruff --fix 13 readability / import / minor style on src/vibepod + tests no
tests python -m pytest -q green locally no
Total 13 ~37 insertions / ~76 deletions

Focused format/ruff fixes from an external ShipGate review run.
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR applies behavior-preserving formatting and whitespace changes across production and test code. No executable logic, output content, exception behavior, or test assertions are changed.

Changes

Formatting cleanup

Layer / File(s) Summary
Production code formatting
scripts/check_default_images.py, src/vibepod/commands/*, src/vibepod/core/*, src/vibepod/compat.py
Reformats messages, signatures, exception strings, conditionals, and image-tag logic without changing behavior.
Test code formatting
tests/test_config.py, tests/test_doctor.py, tests/test_run.py, tests/test_skills_engine_driver.py, tests/test_task_cmd.py
Reformats test setup, assertions, stubs, expressions, signatures, and spacing without changing test behavior.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 21.21% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the PR as a ShipGate-driven CLI readability cleanup pass.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@inquilabee
inquilabee force-pushed the shipgate-readability-fixes branch from fcacf94 to 5e75aa8 Compare July 30, 2026 00:34
@nezhar

nezhar commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Thanks for proposing this.

I will be adding a pipeline for running ruff on every commit.

@inquilabee

Copy link
Copy Markdown
Author

Thanks @nezhar — since you're adding a ruff pipeline on every commit, I'll close this PR and let you handle linting in the way that fits the project. Appreciate the positive response.

@inquilabee inquilabee closed this Jul 30, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants