refactor: replace eval-based dynamic field access with MATLAB idioms#94
Merged
Conversation
Replace eval(strcat('S.', name)) and eval(strjoin({...}, '.')) patterns
with direct dynamic field access (S.(name)) and subsref for dotted paths.
Remove nansen.manage.OptionsAdapter — dead duplicate of
nansen.wrapper.abstract.OptionsAdapter with zero subclasses or callers.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Test Results199 tests 199 ✅ 24s ⏱️ Results for commit 8700719. ♻️ This comment has been updated with latest results. |
Add nansen.internal.introspection.getConstantPropertyValue(className, propName)
as a safe replacement for eval(sprintf('%s.PropName', className)). Uses
meta.class.fromName internally and errors clearly when the class or property
is not found or not Constant.
Replace 9 call sites across Preferences, NansenUserSession, ImageStack,
MetaTable, MetaTableColumnLayout, formatTableForDisplay, OptionsManager (×2),
and App.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval(strcat('S.', name))andeval(strjoin({...}, '.'))patterns with direct dynamic field access (S.(name)) andsubsreffor dotted-path stringseval(sprintf('%s.getBlankItem()', mfilename('class')))withfeval([mfilename('class'), '.getBlankItem'])inSessionMethodsCatalognansen.manage.OptionsAdapter— confirmed dead duplicate ofnansen.wrapper.abstract.OptionsAdapter(zero subclasses, zero callers)Files changed
code/general/+tools/editStruct.mcode/apps/+structeditor/App.mcode/wrappers/+nansen/+wrapper/+abstract/OptionsAdapter.mcode/+nansen/+config/SessionMethodsCatalog.mcode/+nansen/+manage/OptionsAdapter.m(deleted)🤖 Generated with Claude Code