Refactor: replace deprecated datestr/datenum with datetime API#93
Merged
Conversation
Replace all 11 datestr and 1 datenum call sites in the codebase with
the modern datetime API. Most edits are mechanical: datestr(now, fmt)
becomes char(datetime('now'), fmt) with format strings converted from
the legacy spec to ICU (MM=month, mm=minute, SS->ss, sss->SSS).
In StackMetadata.toStruct/fromStruct the legacy format string
'YYYY_MM_DD_HH_MM_SS_sss' was actually rejected by datestr itself
('Unrecognized minute format'), meaning toStruct only worked when
StartTime was empty. Both sites now use 'yyyy_MM_dd_HH_mm_ss_SSS'
and roundtrip correctly.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix code relying on older
datenum/datestrfunctions that are not recommended anymore. Replaced withdatetime.