Skip to content

docs(core): clarify numeric validation expectations #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khanavi272-spec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(core): clarify numeric validation expectations #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions engine-core/src/core/control_plane.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,13 @@ impl ControlPlane {
/// Mutate a protocol parameter securely.
///
/// Security properties:
/// - caller must be the initialized admin and must authorize the invocation;
/// - circuit breaker must be closed;
/// - transition must pass the audit module's chained commitment check;
/// - update counter uses checked arithmetic;
/// - reentrancy guard wraps the full mutation.
/// - caller must be the initialized admin and must authorize the invocation;
/// - circuit breaker must be closed;
/// - transition must pass the audit module's chained commitment check;
/// - numeric parameter values should be validated against protocol-defined limits
/// before being accepted by higher-level configuration flows;
/// - update counter uses checked arithmetic;
/// - reentrancy guard wraps the full mutation.
pub fn update_param(
env: Env,
caller: Address,
Expand Down
Loading