chore: Sync 'master' into 'devel' - #676
Merged
Merged
Conversation
This PR fixes and closes #613. There was no issue with `create_sigma_star_nft`, contrary to what the issue suggested. The problem was in the implementation of `is_in_lang_by_levels`, which is called by `is_in_lang`. In the case of a jump transition, the method did not use the symbol of that transition. Instead, it incorrectly used the first symbol of the input word. As a result, words such as `{'a', 'a'}` correctly passed a `DONT_CARE` jump transition, but words such as `{'a', 'b'}` were incorrectly rejected. Moreover, this bug allowed any word beginning with `DONT_CARE` to be accepted by any jump transition, which is incorrect. For example, the word `{DONT_CARE, 'b'}` was accepted by a jump transition over the repeated symbol `'a'` because every comparison was made against the first symbol of the word (`DONT_CARE`) instead of the symbol on the transition.
Adda0
enabled auto-merge
July 14, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of 'master' into 'devel' after release. Auto-merged when all checks pass.