Skip to content

fix: apply only confirmed style rewrites#4

Merged
imakris merged 1 commit into
masterfrom
fix/style-pipeline-confirmed-writes
Jul 14, 2026
Merged

fix: apply only confirmed style rewrites#4
imakris merged 1 commit into
masterfrom
fix/style-pipeline-confirmed-writes

Conversation

@imakris

@imakris imakris commented Jul 10, 2026

Copy link
Copy Markdown
Member

style_pipeline.py --write advertised confirmed fixes but ran every fixer unconditionally. On an already green vnm_plot tree that changed six files, exited zero, and left the no-write pipeline red.

This change:

  • pre-checks each fixable rule and skips its fixer when already green
  • retains fail-fast precheck/fix/postcheck behavior for confirmed failures
  • performs one complete final read-only sweep after any fixer ran
  • returns nonzero on cross-stage invalidation instead of auto-looping
  • adds runner and concrete condition/hanging fixed-point regression tests

Validation:

  • python tests/test_style_tools.py: 576/576 green
  • vnm_plot@2ec8013 no-write: green
  • vnm_plot@2ec8013 --write: green with zero file changes
  • original dirty standards checkout was not modified

@imakris imakris force-pushed the fix/style-pipeline-confirmed-writes branch from ce01c3a to ce1ef46 Compare July 14, 2026 11:54
@imakris imakris merged commit ad34a3d into master Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant