fix: apply only confirmed style rewrites#4
Merged
Conversation
ce01c3a to
ce1ef46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
style_pipeline.py --writeadvertised confirmed fixes but ran every fixer unconditionally. On an already green vnm_plot tree that changed six files, exited zero, and left the no-write pipeline red.This change:
Validation:
python tests/test_style_tools.py: 576/576 greenvnm_plot@2ec8013no-write: greenvnm_plot@2ec8013 --write: green with zero file changes