fix: correct shortcodes filter query#1525
Open
ChongJiaChua wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker/issues/850
Description
The GraphQL proposals query's shortcodes filter was matching against proposals.proposal_id instead of matching against the call shortcode, causing the filter to always return a empty list. The filter has been updated to correctly perform a query lookup on the call table so that it returns the correct proposals for a given call shortcode.
Motivation and Context
How Has This Been Tested
Sending the query below to the graphql end point with a list of short codes returns the correct list of proposals
Fixes
Changes
Replaced the
query.whereRaw(proposal_id similar to '%(${filteredAndPreparedShortCodes})%'partial string matching inProposalDataSource.tsandStfcProposalDataSource.tswith a subquery that filterscall_idbased on matchingcall_short_codein the call table.Depends on
Tests included/Docs Updated?