feat: a view to show what proposals are assigned to fap reviewers#1496
feat: a view to show what proposals are assigned to fap reviewers#1496TCMeldrum wants to merge 8 commits into
Conversation
Co-authored-by: Copilot <copilot@github.com>
|
Question: would that be possible to add some screenshots, I tis quiet hard for me at least to see what has changed. Thank you. |
|
Have added some screenshots @jekabs-karklins |
Hi, @TCMeldrum |
So sorry I must have forgot to click save 🤦 |
| /** Call this function in case of Fap assigned members update */ | ||
| onAssignmentsUpdate: (fap: Fap) => void; | ||
| /** Call id that we want to filter by */ | ||
| confirm: WithConfirmType; |
There was a problem hiding this comment.
I can't find where this property is used; the comment above doesn't seem to match it.
There was a problem hiding this comment.
Assume you are talking about the confirm type. It is used in combo with this function https://github.com/UserOfficeProject/user-office-core/blob/8f0ac02cdc644087c92a499f0fb1d98b1e0225ff/apps/frontend/src/utils/withConfirm.tsx. You wrap the function in this case (FapReviewersAndAssignmentsTable) with withConfirm to add a conformation promt and uses the confirmed prop.
At least i think thats how it works.
| const FapReviewersAndAssignmentsTable = ({ | ||
| fap, | ||
| onAssignmentsUpdate, | ||
| // confirm, |
There was a problem hiding this comment.
This line is commented out
This looks great - nicely done |
…om/UserOfficeProject/user-office-core into 1572-add-new-reviewers-page-to-fap
Have added the other 2 comments thanks! |
Closes UserOfficeProject/issue-tracker#1572
Description
Implemented a new feature to show assigned proposals to FAP reviewers.
Motivation and Context
The change is required to enhance the visibility of assigned proposals to FAP reviewers, which will help streamline review processes and increase efficiency.
Changes
How Has This Been Tested?
Fixes Jira Issue
https://jira.ess.eu//browse/
Depends On
Tests included/Docs Updated?