Skip to content

feat: a view to show what proposals are assigned to fap reviewers#1496

Open
TCMeldrum wants to merge 8 commits into
developfrom
1572-add-new-reviewers-page-to-fap
Open

feat: a view to show what proposals are assigned to fap reviewers#1496
TCMeldrum wants to merge 8 commits into
developfrom
1572-add-new-reviewers-page-to-fap

Conversation

@TCMeldrum
Copy link
Copy Markdown
Contributor

@TCMeldrum TCMeldrum commented Apr 28, 2026

Closes UserOfficeProject/issue-tracker#1572

Description

Implemented a new feature to show assigned proposals to FAP reviewers.

image image image

Motivation and Context

The change is required to enhance the visibility of assigned proposals to FAP reviewers, which will help streamline review processes and increase efficiency.

Changes

  1. Enabled visibility of the Reviewers to Assignments view, allowing users to see which proposals have been assigned to which reviewers.
  2. Introduced functionality to assign proposals to reviewers in the Reviewers to Assignments view.
  3. Updated the FAP page tab index to reflect the new feature.

How Has This Been Tested?

Fixes Jira Issue

https://jira.ess.eu//browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

Co-authored-by: Copilot <copilot@github.com>
@TCMeldrum TCMeldrum requested a review from a team as a code owner April 28, 2026 14:44
@TCMeldrum TCMeldrum requested review from EdwardHaynes and removed request for a team April 28, 2026 14:44
@jekabs-karklins
Copy link
Copy Markdown
Contributor

Question: would that be possible to add some screenshots, I tis quiet hard for me at least to see what has changed. Thank you.

@TCMeldrum
Copy link
Copy Markdown
Contributor Author

Have added some screenshots @jekabs-karklins

@jekabs-karklins
Copy link
Copy Markdown
Contributor

Have added some screenshots @jekabs-karklins

Hi, @TCMeldrum
Did you add them to the PR? I can't seem to locate

@TCMeldrum
Copy link
Copy Markdown
Contributor Author

Have added some screenshots @jekabs-karklins

Hi, @TCMeldrum Did you add them to the PR? I can't seem to locate

So sorry I must have forgot to click save 🤦

Comment thread apps/e2e/cypress/e2e/FAPs.cy.ts Outdated
/** Call this function in case of Fap assigned members update */
onAssignmentsUpdate: (fap: Fap) => void;
/** Call id that we want to filter by */
confirm: WithConfirmType;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find where this property is used; the comment above doesn't seem to match it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume you are talking about the confirm type. It is used in combo with this function https://github.com/UserOfficeProject/user-office-core/blob/8f0ac02cdc644087c92a499f0fb1d98b1e0225ff/apps/frontend/src/utils/withConfirm.tsx. You wrap the function in this case (FapReviewersAndAssignmentsTable) with withConfirm to add a conformation promt and uses the confirmed prop.

At least i think thats how it works.

const FapReviewersAndAssignmentsTable = ({
fap,
onAssignmentsUpdate,
// confirm,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is commented out

Comment thread apps/frontend/src/components/fap/Proposals/AssignmentsTable.tsx Outdated
Comment thread apps/frontend/src/components/fap/Proposals/AssignmentsTable.tsx Outdated
@Scott-James-Hurley
Copy link
Copy Markdown
Contributor

Scott-James-Hurley commented May 5, 2026

  • Do FAPs want to keep the old way of assigning reviewers as well?
  • When testing locally, I can't seem to sort the table by name
  • An idea for the modal that allows you to assign proposals to the selected reviewers, would it be useful to show the number of reviewers currently assigned to each proposal as well? Just a thought.

This looks great - nicely done

@TCMeldrum
Copy link
Copy Markdown
Contributor Author

Do FAPs want to keep the old way of assigning reviewers as well?
Yeah I think it would be good to keep both ways

Have added the other 2 comments thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have a alternate view fap assignements showing reviewers and what proposals they are assigned to

4 participants