Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/backend/src/models/questionTypes/NumberInput.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ export const numberInputDefinition: Question<DataType.NUMBER_INPUT> = {
config.required = false;
config.tooltip = '';
config.units = [];
config.numberMin = null;
config.numberMinInclusive = false;
config.numberMax = null;
config.numberMaxInclusive = false;
config.readPermissions = [];

return config;
Expand Down
13 changes: 13 additions & 0 deletions apps/backend/src/resolvers/types/FieldConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
Ctx,
Field,
FieldResolver,
Float,
Int,
ObjectType,
Resolver,
Expand Down Expand Up @@ -309,6 +310,18 @@ export class NumberInputConfig extends ConfigBase {

@Field(() => NumberValueConstraint, { nullable: true })
numberValueConstraint: NumberValueConstraint | null;

@Field(() => Float, { nullable: true })
numberMin: number | null;

@Field(() => Boolean, { nullable: true })
numberMinInclusive: boolean | null;

@Field(() => Float, { nullable: true })
numberMax: number | null;

@Field(() => Boolean, { nullable: true })
numberMaxInclusive: boolean | null;
}

@ObjectType()
Expand Down
50 changes: 48 additions & 2 deletions apps/e2e/cypress/e2e/templatesBasic.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ context('Template Basic tests', () => {
);
});

it('should render the Number field accepting only positive, negative numbers if set', () => {
it('should render the Number field accepting only numbers according to the config', () => {
const generateId = () =>
`${faker.lorem.word()}_${faker.lorem.word()}_${faker.lorem.word()}`;

Expand Down Expand Up @@ -738,6 +738,48 @@ context('Template Basic tests', () => {
goodInput: '1',
failureMessage: 'Value must be positive whole number',
},
{
id: generateId(),
title: faker.lorem.words(3),
fieldName: 'numberField2',
numberMin: 0,
numberMax: 10,
badInput: '10',
goodInput: '5',
failureMessage: 'Value must be less than 10',
},
{
id: generateId(),
title: faker.lorem.words(3),
fieldName: 'numberField3',
numberMin: 0,
numberMax: 10,
badInput: '-1',
goodInput: '5',
failureMessage: 'Value must be greater than 0',
},
{
id: generateId(),
title: faker.lorem.words(3),
fieldName: 'numberField4',
numberMin: 0,
numberMax: 10,
numberMaxInclusive: true,
badInput: '10.1',
goodInput: '10',
failureMessage: 'Value must be less than or equal to 10',
},
{
id: generateId(),
title: faker.lorem.words(3),
fieldName: 'numberField5',
numberMin: 0,
numberMax: 10,
numberMinInclusive: true,
badInput: '-0.1',
goodInput: '0',
failureMessage: 'Value must be greater than or equal to 0',
},
];

cy.login('officer');
Expand All @@ -751,6 +793,10 @@ context('Template Basic tests', () => {
units: ['kelvin'],
valueConstraint: question.valueConstraint,
firstTopic: true,
numberMin: question.numberMin,
numberMax: question.numberMax,
numberMinInclusive: question.numberMinInclusive,
numberMaxInclusive: question.numberMaxInclusive,
});
}

Expand Down Expand Up @@ -2095,7 +2141,7 @@ context('Template Basic tests', () => {
);
});

it.only('User officer cannot delete referenced email template', () => {
it('User officer cannot delete referenced email template', () => {
const statusActionConfig = {
recipientsWithEmailTemplate: [
{
Expand Down
26 changes: 25 additions & 1 deletion apps/e2e/cypress/fixtures/template_export.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"metadata": {
"version": "1.2.0",
"exportDate": "2025-10-17T11:23:20.021Z"
"exportDate": "2026-04-15T14:00:17.520Z"
},
"data": {
"template": {
Expand Down Expand Up @@ -119,6 +119,10 @@
"siConversionFormula": "x / 100"
}
],
"numberMin": null,
"numberMinInclusive": false,
"numberMax": null,
"numberMaxInclusive": false,
"readPermissions": [],
"numberValueConstraint": null
}
Expand All @@ -145,6 +149,10 @@
"siConversionFormula": "x / 100"
}
],
"numberMin": null,
"numberMinInclusive": false,
"numberMax": null,
"numberMaxInclusive": false,
"readPermissions": [],
"numberValueConstraint": null
},
Expand Down Expand Up @@ -601,6 +609,10 @@
"siConversionFormula": "x / 100"
}
],
"numberMin": null,
"numberMinInclusive": false,
"numberMax": null,
"numberMaxInclusive": false,
"readPermissions": [],
"numberValueConstraint": null
}
Expand Down Expand Up @@ -1015,6 +1027,10 @@
"siConversionFormula": "x / 100"
}
],
"numberMin": null,
"numberMinInclusive": false,
"numberMax": null,
"numberMaxInclusive": false,
"readPermissions": [],
"numberValueConstraint": null
}
Expand All @@ -1041,6 +1057,10 @@
"siConversionFormula": "x / 100"
}
],
"numberMin": null,
"numberMinInclusive": false,
"numberMax": null,
"numberMaxInclusive": false,
"readPermissions": [],
"numberValueConstraint": null
},
Expand Down Expand Up @@ -1303,6 +1323,10 @@
"siConversionFormula": "x / 100"
}
],
"numberMin": null,
"numberMinInclusive": false,
"numberMax": null,
"numberMaxInclusive": false,
"readPermissions": [],
"numberValueConstraint": null
}
Expand Down
20 changes: 20 additions & 0 deletions apps/e2e/cypress/support/template.ts
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,10 @@ function createNumberInputQuestion(
units?: string[];
valueConstraint?: string;
firstTopic?: boolean;
numberMax?: number;
numberMaxInclusive?: boolean;
numberMin?: number;
numberMinInclusive?: boolean;
}
) {
openQuestionsMenu({
Expand All @@ -533,6 +537,22 @@ function createNumberInputQuestion(
cy.contains(options?.valueConstraint).click();
}

if (options?.numberMin !== undefined) {
cy.get('[data-cy="numberMin"]').clear().type(options.numberMin.toString());

if (options.numberMinInclusive) {
cy.get('[data-cy="numberMinInclusive"]').click();
}
}

if (options?.numberMax !== undefined) {
cy.get('[data-cy="numberMax"]').clear().type(options.numberMax.toString());

if (options.numberMaxInclusive) {
cy.get('[data-cy="numberMaxInclusive"]').click();
}
}

cy.contains('Save').click();

cy.contains(question)
Expand Down
4 changes: 4 additions & 0 deletions apps/e2e/cypress/types/template.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,10 @@ declare global {
units?: string[];
valueConstraint?: string;
firstTopic?: boolean;
numberMax?: number;
numberMaxInclusive?: boolean;
numberMin?: number;
numberMinInclusive?: boolean;
}
) => void;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,39 @@ export const QuestionNumberForm = (props: QuestionFormProps) => {
unit: Yup.string(),
})
),
numberMin: Yup.number()
.typeError('Value must be a number')
.nullable(),
numberMinInclusive: Yup.bool().nullable(),
numberMaxInclusive: Yup.bool().nullable(),
numberMax: Yup.number()
.typeError('Value must be a number')
.nullable()
// We cannot do the same for numberMin because it would create a circular dependency
.when(
['numberMin', 'numberMaxInclusive', 'numberMinInclusive'],
([numberMin, numberMaxInclusive, numberMinInclusive], schema) => {
if (numberMin !== undefined) {
if (numberMinInclusive && numberMaxInclusive) {
return schema.min(
numberMin,
'Maximum must be greater than or equal to Minimum'
);
} else {
return schema.moreThan(
numberMin,
'Maximum must be strictly greater than Minimum'
);
}
}

return schema;
}
),
}),
})}
>
{({ setFieldValue }) => (
{({ setFieldValue, setFieldTouched, values }) => (
<>
<Field
name="naturalKey"
Expand Down Expand Up @@ -186,6 +215,60 @@ export const QuestionNumberForm = (props: QuestionFormProps) => {
},
]}
/>
<Field
name="config.numberMin"
label="Minimum"
id="config.numberMin"
type="number"
component={TextField}
fullWidth
inputProps={{ 'data-cy': 'numberMin' }}
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
const value =
e.target.value === '' ? null : Number(e.target.value);
setFieldValue('config.numberMin', value);
//Trigger validation for numberMax when numberMin changes
setFieldTouched('config.numberMax', true, true);
}}
/>
{(values.config as NumberInputConfig).numberMin !== null && (
<Field
name="config.numberMinInclusive"
id="config.numberMinInclusive"
type="checkbox"
component={CheckboxWithLabel}
Label={{
label: 'Minimum is inclusive',
}}
inputProps={{ 'data-cy': 'numberMinInclusive' }}
/>
)}
<Field
name="config.numberMax"
label="Maximum"
id="config.numberMax"
type="number"
component={TextField}
fullWidth
inputProps={{ 'data-cy': 'numberMax' }}
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
const value =
e.target.value === '' ? null : Number(e.target.value);
setFieldValue('config.numberMax', value);
}}
/>
{(values.config as NumberInputConfig).numberMax !== null && (
<Field
name="config.numberMaxInclusive"
id="config.numberMaxInclusive"
type="checkbox"
component={CheckboxWithLabel}
Label={{
label: 'Maximum is inclusive',
}}
inputProps={{ 'data-cy': 'numberMaxInclusive' }}
/>
)}
</TitledContainer>
<StyledDialog
aria-labelledby="simple-modal-title"
Expand Down
Loading
Loading