Add new log level: TRACE (5)#1927
Conversation
|
Warning 1 of 1 new test names are missing convention keywords (
Why am I seeing this?Test names should follow a loose given/when/then pattern with keywords like Examples:
|
.. in case anything run during setting up settings logs anything.
Test results 8 files 1 720 suites 2m 57s ⏱️ Results for commit 469c044. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1927 +/- ##
==========================================
- Coverage 88.60% 88.53% -0.08%
==========================================
Files 146 147 +1
Lines 7093 7115 +22
==========================================
+ Hits 6285 6299 +14
- Misses 808 816 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This should probably be documented somewhere, but I'm not sure where. It is an addition/alteration to standard python. |
aleksfl
left a comment
There was a problem hiding this comment.
Seems to works as it should, and looks alright. Some comments on things that looked apparent.
| setattr(logging.Logger, level_name.lower(), log_with_custom_level) | ||
|
|
||
|
|
||
| _add_logging_level("TRACE", 5) |
There was a problem hiding this comment.
Does it not make more sense to use the setup_logging method for consistency?
There was a problem hiding this comment.
It's an ugly hack so that readthedocs builds.
Doing it like this makes it impossible to test without this function having been run. Using setup_logging won't change that.
|
aleksfl
left a comment
There was a problem hiding this comment.
Did some final testing, my comments were addressed. All good.




Scope and purpose
In order to be able to filter logs better in production I want to add an additional log level, for debugging at an even higher level of detail.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.