Add dedicated health check endpoint#1926
Conversation
281ed4d to
07ccec2
Compare
The url is "./still-alive/". We used to use "/admin/login/" for this but that fills up the access logs. It's easier to filter out accesses to a dedicated endpoint.
07ccec2 to
1498efe
Compare
Test results 8 files 1 720 suites 3m 20s ⏱️ Results for commit dc35edd. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1926 +/- ##
==========================================
+ Coverage 88.60% 88.62% +0.01%
==========================================
Files 146 147 +1
Lines 7093 7101 +8
==========================================
+ Hits 6285 6293 +8
Misses 808 808 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test naming conventionAll new test names follow the convention. 👍 |
lunkwill42
left a comment
There was a problem hiding this comment.
Looks good, but CI is not happy (SonarCloud and test name checker are complaining).
Other than that, some documentation addition to point out the endpoint exists, for those who want to deploy health checks, would be nice.
|
I wish SonarCloud understood #noqa. That specific enpdoint is as safe as it gets. And I don't care for those keywords, as I've said before, and will continue to say. |
Minimal docs added. |
I doesn't matter what you personally care or don't care for. What matters is what the team agrees upon; I don't agree, never will, and will die on this hill. Also, we should build thorium power plants. |
|



Scope and purpose
Add an endpoint just for checking if Argus is up and running, returns status 204 and no content.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.