Skip to content

Systematize names: some easy pickings#1015

Merged
hmpf merged 10 commits into
Uninett:masterfrom
hmpf:singularize-easy-pickings
Dec 10, 2024
Merged

Systematize names: some easy pickings#1015
hmpf merged 10 commits into
Uninett:masterfrom
hmpf:singularize-easy-pickings

Conversation

@hmpf
Copy link
Copy Markdown
Contributor

@hmpf hmpf commented Nov 29, 2024

Adapted from Uninett/argus-htmx-frontend#230

Whether the name of something is singular or plural is a bit of a mess. Django custom is singular for models, modelname_list in template names that handles more than one of model-name's instances.

These are the easiest pickings.

Bonus: renaming the template for the checkbox to select all incidents to a name that better reflects that.

What remains are:

  • htmx/themes
  • htmx/incidents
  • htmx/destinations

Renaming htmx/incidents to htmx/incident will be the big one.

"preferences" stays plural since one instance of the Preferences model contains multiple preferences. (Maybe the Preferences-model could be renamed to "PreferenceNamespace").

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.19%. Comparing base (0e44800) to head (c69df7f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/argus/htmx/incidents/views.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1015   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files         140      140           
  Lines        5074     5074           
=======================================
  Hits         4120     4120           
  Misses        954      954           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf hmpf self-assigned this Dec 2, 2024
@hmpf hmpf force-pushed the singularize-easy-pickings branch 4 times, most recently from 18d0954 to 6ac9e0e Compare December 9, 2024 12:34
@hmpf hmpf force-pushed the singularize-easy-pickings branch from 6ac9e0e to 2177240 Compare December 9, 2024 12:50
Copy link
Copy Markdown
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested manually with HTMX frontend and nothing seems to break there

@sonarqubecloud
Copy link
Copy Markdown

@hmpf hmpf merged commit bc31fca into Uninett:master Dec 10, 2024
@hmpf hmpf deleted the singularize-easy-pickings branch December 10, 2024 10:16
@hmpf
Copy link
Copy Markdown
Contributor Author

hmpf commented Dec 18, 2024

htmx/destinations were renamed via #970.

@hmpf
Copy link
Copy Markdown
Contributor Author

hmpf commented Dec 18, 2024

htmx/incidents is handled by #1098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants