Add extra failure handling to the daos inferencing #3238
+22
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re: Issue Unidata#3195 ## Primary change In the isdaoscontainer() function the config.h value HAVE_SYS_XATTR_H should always be enabled (except for Windows). This allows the daos check to be performed using system calls. The above issue claims to have a situation where it is not windows and HAVE_SYS_XATTR_H is fals. If HAVE_SYS_XATTR_H is false, then isdaoscontainer() falls back to invoking a command line program: getfattr. The availability of getfattr is tested in configure.ac and CMakeLists.txt. If available, then it is invoked using popen(). It is here (!HAVE_SYS_XATTR_H && HAVE_GETFATTR), that we modified to code to add extra support in case getfattr fails for whatever reason. ## Secondary changes 1. getxattr and listxattr have an extra argument under OS/X. So create some macros to mask this extra argument, which is always 0. 2. add a check in configure.ac for strndup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: Issue #3195
Primary change
In the isdaoscontainer() function the config.h value HAVE_SYS_XATTR_H should always be enabled (except for Windows). This allows the daos check to be performed using system calls.
The above issue claims to have a situation where it is not windows and HAVE_SYS_XATTR_H is fals.
If HAVE_SYS_XATTR_H is false, then isdaoscontainer() falls back to invoking a command line program: getfattr. The availability of getfattr is tested in configure.ac and CMakeLists.txt. If available, then it is invoked using popen().
It is here (!HAVE_SYS_XATTR_H && HAVE_GETFATTR), that we modified to code to add extra support in case getfattr fails for whatever reason.
Secondary changes