Skip to content

Santises the variables containing dots - #629

Merged
katrinafyi merged 3 commits into
mainfrom
sanitise
May 21, 2026
Merged

Santises the variables containing dots#629
katrinafyi merged 3 commits into
mainfrom
sanitise

Conversation

@JTrenerry

Copy link
Copy Markdown
Member

#627 FIxes the TODO section of that PR.

Removes dots from variables names when printing to IR.

@JTrenerry
JTrenerry requested review from agle and katrinafyi May 19, 2026 02:02
@JTrenerry JTrenerry self-assigned this May 19, 2026
@JTrenerry JTrenerry added the bug Something isn't working label May 19, 2026
@JTrenerry
JTrenerry removed request for agle and katrinafyi May 19, 2026 02:02
@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

scalafmt check passed.

last updated at 2956cd2 (logs).

@JTrenerry
JTrenerry requested a review from katrinafyi May 19, 2026 03:15
@JTrenerry

Copy link
Copy Markdown
Member Author

@katrinafyi can you also update the pac-nix when this is merged so I can run the benchmarks overnight again :(

Comment thread src/main/scala/translating/PrettyPrinter.scala Outdated

@katrinafyi katrinafyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just gonna push this through to make it work, even if I don't love the idea. bincaml frontend will come soon™.

@JTrenerry

Copy link
Copy Markdown
Member Author

just gonna push this through to make it work, even if I don't love the idea. bincaml frontend will come soon™.

thank you 😭

@katrinafyi
katrinafyi merged commit f1fbb7b into main May 21, 2026
22 of 23 checks passed
@katrinafyi
katrinafyi deleted the sanitise branch May 21, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants