improve(logger): Update @google-cloud/logging-winston dependency#4779
Open
nicholaspai wants to merge 2 commits intomasterfrom
Open
improve(logger): Update @google-cloud/logging-winston dependency#4779nicholaspai wants to merge 2 commits intomasterfrom
nicholaspai wants to merge 2 commits intomasterfrom
Conversation
This has an upstream dependency on
nicholaspai
requested review from
Reinis-FRP,
chrismaree,
daywiss,
md0x and
mrice32
as code owners
james-a-morris
approved these changes
Aug 15, 2024
Contributor
james-a-morris
left a comment
james-a-morris
left a comment
There was a problem hiding this comment.
lgtm - will recommend we get a signoff from someone closer to this
daywiss
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This has an upstream dependency on
protobufjs@6.11.3which has a vulnerability and is likely to cause any downstream clients issues if they run any package dependency checks on this package.Summary
Update the
@google-cloud/logging-winstonto the latest version