fix(ui5-toolbar): handle non-ToolbarItem children in width calculation #12923
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Deployed on https://pr-12923--ui5-webcomponents-preview.netlify.app |
Use item._individualSlot instead of item.slot when querying rendered
items. For non-ToolbarItem elements, item.slot is an empty string (""),
which creates an invalid CSS selector "#" and causes a SyntaxError.
This particularly affects @ui5/webcomponents-react applications using
conditional rendering with regular HTML elements.
Fixes: #12855
kgogov
force-pushed
the
fix-toolbar-items
branch
from
702e6f3 to
3d0403b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
item._individualSlotinstead ofitem.slotwhen querying rendered items. For non-ToolbarItem elements,item.slotis an empty string (""), which creates an invalid CSS selector "#" and causes a SyntaxError.This particularly affects
@ui5/webcomponents-reactapplications using conditional rendering with regular HTML elements.Fixes: #12855