Prevented multiple messages from sending on single call#975
Merged
Conversation
raghumanimehta
left a comment
raghumanimehta
left a comment
Contributor
There was a problem hiding this comment.
Question: Does returning false lead to more frequent failures?
Contributor
no. we also cant determine if the message sent but a separate failure happened without some kind of handshake with the receiving end. |
Contributor
Author
|
If it becomes a problem, then we can go back to retrying for actual send() when we launch. We can reduce the limit from 20 to 5 so credit usage doesn't blow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #934
Multiple sends were happening in the same call because something in the loop failed and caused a retry after the send command completed successfully.
Changed the failures after a successful send command to immediately return instead of retrying.
Also changed the retry limit from 20 to 5.