Updated CAN Frames#972
Merged
Merged
Conversation
raghumanimehta
previously approved these changes
Jun 27, 2026
Contributor
|
Please ensure the filtering for debug frames is correct per CAN frame documentation. For example, the pressure sensors (now removed entirely) occupy the frame IDs of the heart beat frames. I filtered them out as a hotfix for the OWT, but we need to ensure all the software frame IDs match the documentation and are filtered correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated CAN frames based on Confluence Page dated Oct 29, 2025. Resolves #809
It seemed like some of the previous code was buggy, and the
toLinuxCan()vs the decoding functions performed slightly different calculations. I made them match, but I'm unsure if it's fully correct.Also added the logic to set the steering enable bit to 1 (which actually disables steering) if PATH sets
sailto false. Resolves #964