Skip to content

Updated CAN Frames#972

Merged
lross03 merged 15 commits into
mainfrom
user/Apps247/can-frames-update
Jul 4, 2026
Merged

Updated CAN Frames#972
lross03 merged 15 commits into
mainfrom
user/Apps247/can-frames-update

Conversation

@Apps247

@Apps247 Apps247 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Updated CAN frames based on Confluence Page dated Oct 29, 2025. Resolves #809

It seemed like some of the previous code was buggy, and the toLinuxCan() vs the decoding functions performed slightly different calculations. I made them match, but I'm unsure if it's fully correct.

Also added the logic to set the steering enable bit to 1 (which actually disables steering) if PATH sets sail to false. Resolves #964

@Apps247 Apps247 requested review from Jng468 and lross03 as code owners June 26, 2026 10:26
@raghumanimehta raghumanimehta self-requested a review as a code owner June 27, 2026 01:34
raghumanimehta
raghumanimehta previously approved these changes Jun 27, 2026

@raghumanimehta raghumanimehta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this for the part that concerns pathfinding. I haven't looked at the rest of the code so don't merge befor @lross03 and / or @Jng468's approval.

@lross03

lross03 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Please ensure the filtering for debug frames is correct per CAN frame documentation. For example, the pressure sensors (now removed entirely) occupy the frame IDs of the heart beat frames. I filtered them out as a hotfix for the OWT, but we need to ensure all the software frame IDs match the documentation and are filtered correctly.

// REMOVE PRESSURE SENSORS PROPERLY (hotfix for on water test)
if (
(id >= CanId::DEBUG_START && id <= CanId::DEBUG_END) ||
(id >= CanId::PRESSURE_SENSOR_START && id <= CanId::PRESSURE_SENSOR_END)) {
// ELEC debug frame, do nothing
return;
}

@lross03 lross03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above comment

@lross03 lross03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lross03 lross03 merged commit 53c4638 into main Jul 4, 2026
6 checks passed
@lross03 lross03 deleted the user/Apps247/can-frames-update branch July 4, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NET: set heading bit to 1 to inform ELEC to stop trying to turn the boat Update CAN frames as of 02/2026

3 participants