Skip to content

Fix loopback interface for MacOS#3799

Merged
Andrewyx merged 3 commits into
masterfrom
avah/macos_plotjuggler_interface
Jun 25, 2026
Merged

Fix loopback interface for MacOS#3799
Andrewyx merged 3 commits into
masterfrom
avah/macos_plotjuggler_interface

Conversation

@nycrat

@nycrat nycrat commented Jun 23, 2026

Copy link
Copy Markdown
Member

Description

On MacOS, the loopback interface is "lo0" and not "lo" like it is on Linux. This PR just adds a helper function to get the loopback interface depending on the OS. Originally found this issue when trying to use plotjuggler on mac.

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat nycrat force-pushed the avah/macos_plotjuggler_interface branch from a0708ba to 8327bf5 Compare June 23, 2026 22:05
sauravbanna
sauravbanna previously approved these changes Jun 24, 2026
williamckha
williamckha previously approved these changes Jun 24, 2026
Comment thread src/software/networking/udp/network_utils.h Outdated
@nycrat nycrat dismissed stale reviews from williamckha and sauravbanna via 6fc0de6 June 24, 2026 00:43
williamckha
williamckha previously approved these changes Jun 24, 2026
@nycrat nycrat force-pushed the avah/macos_plotjuggler_interface branch 2 times, most recently from 92e6e9f to dab8430 Compare June 24, 2026 00:56
@nycrat nycrat requested a review from williamckha June 24, 2026 00:56
williamckha
williamckha previously approved these changes Jun 24, 2026
@nycrat nycrat force-pushed the avah/macos_plotjuggler_interface branch from dab8430 to 8327bf5 Compare June 24, 2026 01:14
@nycrat nycrat mentioned this pull request Jun 24, 2026
4 tasks
williamckha
williamckha previously approved these changes Jun 24, 2026
@Andrewyx Andrewyx requested a review from williamckha June 25, 2026 04:47

@Andrewyx Andrewyx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 💯

@Andrewyx Andrewyx merged commit 0e4d417 into master Jun 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants