Feat hvfb test#3791
Open
noah-m wants to merge 5 commits into
Open
Conversation
noah-m
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
…into feat-hvfb-test
GrayHoang
reviewed
Jun 21, 2026
| pinMode(ADC_MISO, INPUT); | ||
|
|
||
| // Do not touch CH_SEL in this proof-of-concept. | ||
| // Hardware should pull CH_SEL low to select CH0. |
Contributor
There was a problem hiding this comment.
is this comment necessary? Delete if not
| digitalWrite(CHRG, HIGH); | ||
|
|
||
| // last_charge_edge_ms = millis(); | ||
| // has_seen_done_since_last_charge_edge = false; |
Comment on lines
+44
to
+57
| // if (done) | ||
| // { | ||
| // has_seen_done_since_last_charge_edge = true; | ||
| // return; | ||
| // } | ||
|
|
||
| // Minimal "continuous charging" approximation: | ||
| // If the LT3750 previously reached DONE and later DONE deasserts, produce | ||
| // another rising edge to start a new charge cycle. | ||
| // if (has_seen_done_since_last_charge_edge && | ||
| // (millis() - last_charge_edge_ms) > MIN_CHARGE_RETRIGGER_INTERVAL_MS) | ||
| // { | ||
| // chargeCapacitors(); | ||
| // } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue