Skip to content

fix(error): align Go bindings with Error Specification ADR#7

Merged
yordis merged 1 commit into
mainfrom
yordis/fix-align-error-bindings
May 6, 2026
Merged

fix(error): align Go bindings with Error Specification ADR#7
yordis merged 1 commit into
mainfrom
yordis/fix-align-error-bindings

Conversation

@yordis

@yordis yordis commented May 6, 2026

Copy link
Copy Markdown
Member
  • Keeps the Go module aligned with the latest published trogon-proto error contract.
  • Prevents downstream Go consumers from compiling against stale visibility constants.
  • Keeps generated metadata comments consistent with the shared Google RPC projection.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • gen/trogon/consistency/v1alpha1/consistency.pb.go is excluded by !**/*.pb.go, !**/gen/**
  • gen/trogon/error/v1alpha1/options.pb.go is excluded by !**/*.pb.go, !**/gen/**
  • gen/trogon/error/v1alpha1/visibility.pb.go is excluded by !**/*.pb.go, !**/gen/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1c4c5cde-46fb-4c45-b94c-1e3bb877f572

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/fix-align-error-bindings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yordis yordis merged commit e0174f9 into main May 6, 2026
4 checks passed
@yordis yordis deleted the yordis/fix-align-error-bindings branch May 6, 2026 05:57
@sht-bot sht-bot mentioned this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant