Fix the failure of Issue256Test.#1046
Merged
marci4 merged 1 commit intoTooTallNate:masterfrom Jul 28, 2020
Merged
Conversation
marci4
requested changes
Jul 22, 2020
Contributor
Author
|
New Version. The issue347Test in #347, which is written by @oakkitten, has the same problem. |
Collaborator
|
@dota17 thx a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the failure of issue256Test.
Why
issue256Testwould always fail when we run the first test?It is because we got the incompletes current thread in the method
ThreadCheck.before(), when it went too fast so that the server's workers were not all started.After the first test, we could got the completes current thread in the next tests because at the time the server was ready and all its workers were started. Thus, the next tests would success.