bug fix: fix the but where app loaded config before CLI parser parsed the input.#42
Open
lyuwen wants to merge 1 commit into
Open
bug fix: fix the but where app loaded config before CLI parser parsed the input.#42lyuwen wants to merge 1 commit into
lyuwen wants to merge 1 commit into
Conversation
… the input. feat: added Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug happens when I pass in a custom
--backends http://xxx.xxx.xxx.xxx:30000from CLI, but it did not take effect. Thethuneragentstill listens to the localhost:8000. Upon investigation, theregister_routesmethod in app.py was triggered during import via__init__.py. Therefore, as the fix to the bug, I commented out the import from .app since it's not used immediately by the module.