Ultra Low Power deepsleep by hallard · Pull Request #15 · TheThingsNetwork/arduino-node-lib

hallard · 2018-03-01T12:33:50Z

Added Ultra Low Power mode (30uA sleep mode)
Wake by LoRa module, avoid watchdog wake every 8s
Added new method to read battery voltage, needed if VCC<2.5V
Updated documentation
Bug fix with button wake
Press button more than 2s to enable 1minute window to upload new sketch when in deepsleep

- Added Hardware Reset of lora module at startup - Fixed push button duration bug - Set IRQ var to be volatile

Moved #include definition here Added wakeStatus to wakeCallback to get what waked us Added pointer to TheThingsNetwork object to enable Lora module sleep/wake up

removed #include definition (in .h now) Added wakeStatus bit field to wakeCallback to get what waked us Added pointer to TheThingsNetwork object to enable Lora module sleep/wake up Added IRQ for INT2 (Lora Serial Module) Added new configInterval method Optimized Light Sensor Changed deepSleep to support wake by lora module

johanstokking

Nice, thanks very much! Mostly code style issues.

Also looping in @laurensslats for testing

johanstokking · 2018-03-02T14:06:19Z

-void wake() {
-    node->setColor(TTN_GREEN);
+void wake(uint8_t wakeReason) {
+  debugSerial.print(F("Wake Reason:0x"));


Spacing; Reason: 0x

johanstokking · 2018-03-02T14:06:34Z

+  debugSerial.print(F("Wake Reason:0x"));
+  debugSerial.println(wakeReason,HEX);
+
+  if (wakeReason&TTN_WAKE_WATCHDOG) {


Spacing; wakeReason & TTN_WAKE_WATCHDOG

johanstokking · 2018-03-02T14:06:44Z

-    node->setColor(TTN_GREEN);
+void wake(uint8_t wakeReason) {
+  debugSerial.print(F("Wake Reason:0x"));
+  debugSerial.println(wakeReason,HEX);


Spacing; wakeReason, HEX

johanstokking · 2018-03-02T14:07:25Z

 ```

 - `bool enabled`: Enable or disable the interval callback. Enabled automatically by `onInterval()`, but you can use this method to temporarily disable it. Defaults to `false`.
+- `TheThingsNetwork * pttn`: This enable the interval callback but in this mode, the interval is passed to RN2483 or RN2903 module (this is why we need to pass pointer to object) with the command `sys sleep ms` and then it's the LoRa module that wake up the node. This is the most advanced Low Power Mode. In this mode, the watchdog is disabled and consuption again reduced.


consuMption

johanstokking · 2018-03-02T14:09:43Z

-  debugSerial.print(timepressed);
-  debugSerial.println(F(" ms"));
+  snprintf_P(buf, sizeof(buf), PSTR("-- SEND: BUTTON %d ms"), timepressed);
+  debugSerial.println(buf);


Build the string here with print/println calls for consistency

johanstokking · 2018-03-02T14:18:15Z

+  value = readADCLowNoise(true);
+
+  // Vcc reference in millivolts
+  vcc =  ( 1023L * 1100L) / value ; 


johanstokking · 2018-03-02T14:18:25Z

+
+  // Operating range of ATMega
+  if (vcc < 1800 ) vcc = 1800 ;
+  if (vcc > 5500 ) vcc = 5500 ;


Spacing and indentation

johanstokking · 2018-03-02T14:18:40Z

+  if (vcc > 5500 ) vcc = 5500 ;
+
+  // Vcc in millivolts
+  return ( vcc ); 


Why parentheses?

johanstokking · 2018-03-02T14:18:54Z


-  // hardware reset of LoRa module, so module is reset on sketch upload 
-  #ifdef TTN_LORA_RESET
+  // reset RN2483 module, this allow to reset module on sketch upload also


johanstokking · 2018-03-02T14:19:13Z

+    cli();  
+    bitSet(EIFR,INTF2); // clear any pending interrupts for serial RX pin (INT2 D0)
+    sei();
+


Remove empty line

hallard · 2018-03-02T15:35:27Z

@johanstokking you want me to remove any use of printf, sprintf and snprintf, correct?

hallard · 2018-03-04T15:19:59Z

Requested changes are done

johanstokking · 2018-03-04T15:43:26Z

@hallard we try to keep dynamic memory allocations to a minimum, at least that's a goal!

see https://www.thethingsnetwork.org/forum/t/the-things-node-whats-this-3-2ma-sleep-mode-set-to-30ua-now/12521/160

hallard · 2018-03-04T16:40:12Z

removing printf is not a bad idea, I think it also save same pgm space (as soon as it's not used anywhere else in any lib)

CLAassistant · 2019-07-23T17:56:56Z

All committers have signed the CLA.

hallard added 30 commits February 12, 2018 01:47

bugfix and features

756ea4e

- Added Hardware Reset of lora module at startup - Fixed push button duration bug - Set IRQ var to be volatile

Added Low Power Example

32dbe97

Creation

0b21e93

Added Lora Module Sleep Mode

4ba708b

Fixed link

6b736c6

bump to version 2.0.3

6bed71f

force cast of CONFIG_INTERVAL #define

c9869a7

Only TTN Core team allowed to increase version

939b983

Cosmetic

8dfc171

cosmetic formating

c9c05ea

Added missing include

54ef098

Requires TheThingsNode library 2.5.6

5738e06

Added option to wake by lora module

193cfbd

Moved #include definition here Added wakeStatus to wakeCallback to get what waked us Added pointer to TheThingsNetwork object to enable Lora module sleep/wake up

Fix Lora Module Sleep

0f7bcab

Fix IRQ problem on Serial Wake not detected

e599abb

Added new sleep mode with LoRa module

c0941a1

cosmetic

a3a83ca

Updated to new Ultra Low Power Sleep Mode (with LoRa module wake)

1a56e3b

Detailled Low Power Mode

d650ce8

Merge remote-tracking branch 'upstream/master'

59ecaec

Added getVCC() using with ADC Low Noise Feature

e58ab86

Get VCC of ATMega with getVCC()

348990c

Fixed button release bug

bda7d59

send all VDD/VCC/VRN values

b9200a3

Added The Thing Network Library 2.5.7

a005ef8

use of sprintf_p and some cosmetics

72108db

Disable USB Regulator on deep sleeep

ef70b27

Added Ultra Low Power mode

1328207

send wakeSatus to intervall callback

868672a

hallard added 3 commits March 1, 2018 12:35

fix code dispkay

f08d648

Updated for Ultra Low Power

05f454d

secrure printf and set channel 10 for button duration

940f4a2

hallard mentioned this pull request Mar 1, 2018

Battery voltage sensor stops working if battery voltage drops below around 3 volts #14

Open

hallard added 3 commits March 1, 2018 13:43

updated onInterval method()

d5f613a

fixed wake with wakeReason parameter

1f40038

fixed call of wake and interval

6b5c7bb

hallard mentioned this pull request Mar 1, 2018

The Things Node button release does not provide time pressed #9

Closed

fix var name error

60bfe4b

johanstokking requested changes Mar 2, 2018

View reviewed changes

johanstokking requested a review from laurensslats March 2, 2018 14:19

hallard added 7 commits March 4, 2018 16:01

renamed getVcc to getVCC

71b9c68

renamed getVcc to getVCC and cosmetic

03cc19e

renamed getVcc to getVCC

14c691d

renamed getVcc to getVCC

b7f84ae

costemic requested by johan

080d0a2

removed all printf reference

8766972

removed printf reference requested by johan

d5c4d39

hallard added 2 commits March 4, 2018 17:23

Clarification about sensor working mode

58c2004

see https://www.thethingsnetwork.org/forum/t/the-things-node-whats-this-3-2ma-sleep-mode-set-to-30ua-now/12521/160

Updated temp sensor to Low Power

070e3c0

hallard added 4 commits March 5, 2018 21:45

Added delay on wake if temp sensor was in power down mode

2f79a32

fix push button debouncing in IRQ

43fd013

Disable Sleep mode in USB

b53521d

Disabled sleep mode in USB

f326e60

jpmeijers mentioned this pull request May 9, 2022

Basic.ino issue #29

Open

Conversation

hallard commented Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johanstokking left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hallard commented Mar 2, 2018

Uh oh!

hallard commented Mar 4, 2018

Uh oh!

johanstokking commented Mar 4, 2018

Uh oh!

hallard commented Mar 4, 2018

Uh oh!

CLAassistant commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hallard commented Mar 1, 2018 •

edited

Loading

CLAassistant commented Jul 23, 2019 •

edited

Loading