Refactor config tab container CSS selectors#199
Merged
jonathangreen merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
2 tasks
tdilauro
approved these changes
Feb 26, 2026
Contributor
tdilauro
left a comment
tdilauro
left a comment
There was a problem hiding this comment.
This is a nice change. Looks like it should work as expected.
…() exclusions The broad `ul:not(...)` selector in config_tab_container.scss required every new component with a <ul> inside .tab-content to add itself to the exclusion list. Since the rule only targets the <ul> inside EditableConfigList's .list-container, scope it there directly with `.list-container > ul`. This also removes the li:not(.panel):not(.announcement) exclusions which are unnecessary once the ul is properly scoped.
jonathangreen
force-pushed
the
chore/refactor-config-tab-container-selectors
branch
from
23d5f98 to
3d28717
Compare
jonathangreen
deleted the
chore/refactor-config-tab-container-selectors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the broad
ul:not(.input-list-ul):not(.announcements-ul):not(.debug-results-list)selector inconfig_tab_container.scsswith a positively scoped.list-container > ulselector. Also removes theli:not(.panel):not(.announcement)exclusions which should be unnecessary once theulis properly scoped.Motivation and Context
The previous approach required every new component rendering a
<ul>inside.tab-contentto add itself to a growing:not()exclusion list. This was the root cause of the!importantoverrides needed in the debug authentication styles.From what I can tell, the rule only ever targets the bare
<ul>rendered byEditableConfigListinside.list-container(line 168), and no<li>elements inside that<ul>have.panelor.announcementclasses. But given the accumulated tech debt with all the negative selectors, it's hard to be fully confident there isn't an edge case I'm missing. Initial visual inspection of the config list pages looks fine, but this could use extra eyes.Stacked on #198.
How Has This Been Tested?
Checklist: